Re: small tun(4) improvement

2004-10-15 Thread Gleb Smirnoff
On Thu, Oct 14, 2004 at 10:48:32PM +0200, Andre Oppermann wrote: A> > We are going to have triple cut'n'paste: if_tun.c, ng_device.c, if_tap.c. A> > What about m_uiocopy()? The question is where can we put this function? A> A> What about the existing m_uiotombuf() function in kern/uipc_mbuf.c? Da

Re: small tun(4) improvement

2004-10-15 Thread Gleb Smirnoff
On Thu, Oct 14, 2004 at 04:23:42PM -0700, Julian Elischer wrote: J> yes I know, that's how we wrote divert.. (to be independent) netgraph J> came later.. J> I guess we would have done divert differently if we had done netgraph J> first.. J> probably would have given ipfw a "hook" command that se

[PATCH] Make em(4) use device sysctl tree

2004-10-15 Thread Bruce M Simpson
Here is a non-critical patch to bring em(4) into line with other drivers, by using the sysctl tree created for each device by the bus framework. Please review; Thanks. BMS Index: if_em.c === RCS file: /home/ncvs/src/sys/dev/em/if_em.c

Re: small tun(4) improvement

2004-10-15 Thread Bruce M Simpson
On Thu, Oct 14, 2004 at 09:42:25PM +0400, Gleb Smirnoff wrote: > any objections about commiting this improvement to tun(4)? Optimal use of mbuf clusters to improve performance is cool. Please consider committing this once reworked to use m_uiotombuf. BMS

Re: [PATCH] Make em(4) use device sysctl tree

2004-10-15 Thread Maxime Henrion
Bruce M Simpson wrote: > Here is a non-critical patch to bring em(4) into line with other > drivers, by using the sysctl tree created for each device by the > bus framework. > > Please review; Thanks. > BMS [patch ripped] Looks good to me. Cheers, Maxime _

Re: [PATCH] Make em(4) use device sysctl tree

2004-10-15 Thread Petri Helenius
Bruce M Simpson wrote: Here is a non-critical patch to bring em(4) into line with other drivers, by using the sysctl tree created for each device by the bus framework. Does anyone here have an idea why some platforms (like Thinkpad X31 or i875 Supermicros) have trouble rebooting with 5.3-BETA w