patch to cleanup inflight desciptor handling.

2000-12-13 Thread Alfred Perlstein
Not a lot of people are familiar with fd passing so I'll give a short description: By using AF_UNIX sockets between processes, a process can use sendmsg() to send a filedescriptor through the socket where the other process will do a recvmsg() to pickup the descriptor. The "problem" is that

Re: MEXT_IS_REF broken.

2000-12-13 Thread Garrett Wollman
< said: > Gee, this looks suspiciously like jhb's refcount patch: ...Except that I made provision for architectures which have LL/SC rather than CAS, which saves a few instructions. -GAWollman To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-net" in the body of the me

Re: Confusing netgraph error

2000-12-13 Thread Julian Elischer
Mark Wright wrote: > > I'm trying to get frame relay working with a lmc1200 card, and I'm getting > the following error: > > sj# ngctl mkpeer lmc0: frame_relay rawdata downstream > sj# ngctl mkpeer lmc0:rawdata lmi dlci0 auto0 > sj# ngctl mkpeer lmc0:rawdata rfc1490 dlci15 downstream > ngctl: se

Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Bosko Milekic
Hi, A while ago (it's been at least two weeks now), Mike Silbersack requested a review for: http://www.silby.com/patches/ratelimit-enhancement-2.patch To quote the description on his web page, this diff will: * ICMP ECHO and TSTAMP replies are now rate-limited. * RSTs gene

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Richard A. Steenbergen
On Wed, 13 Dec 2000, Bosko Milekic wrote: >Suppressing udp flood/scan: 212/200 pps >Suppressing outgoing RST due to port scan: 202/200 pps >Suppressing outgoing RST due to ACK flood: 19725/200 pps >Suppressing ping flood: 230/200 pps >Suppressing icmp tstam

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Alfred Perlstein
* Richard A. Steenbergen <[EMAIL PROTECTED]> [001213 11:17] wrote: > On Wed, 13 Dec 2000, Bosko Milekic wrote: > > >Suppressing udp flood/scan: 212/200 pps > >Suppressing outgoing RST due to port scan: 202/200 pps > >Suppressing outgoing RST due to ACK flood: 19725/200 pps

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Mike Silbersack
On Wed, 13 Dec 2000, Richard A. Steenbergen wrote: > I would be extremely careful with those descriptions... When you tell > people directly that something is an attack, even if its not, there are > enough who will jump to immediate conclusions and begin making false > accusations. While it may

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Richard A. Steenbergen
On Wed, 13 Dec 2000, Alfred Perlstein wrote: > I think the word "possible" should be prepended to all of these messages. > > Now I have a weird question, I've seen the ICMP responce limit when > getting pegged by a couple hundred hits per second on a port that isn't > open by legimitimate connec

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Richard A. Steenbergen
On Wed, 13 Dec 2000, Mike Silbersack wrote: > > I also see no compelling reason to put ICMP Timestamp > > in a seperate queue, but what I would recommend is seperate queues for > > ICMP messages which would be defined as "query/response" and those which > > would be called "error" messages. If so

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Mike Silbersack
On Wed, 13 Dec 2000, Richard A. Steenbergen wrote: > Is there some specific reason you need timestamp seperate? If you're > really up for that, why not just limit each ICMP type seperately? There's no real need for it to be separate, it just feels cleaner. I prefer seeing the two cases have se

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Richard A. Steenbergen
On Wed, 13 Dec 2000, Mike Silbersack wrote: > On Wed, 13 Dec 2000, Richard A. Steenbergen wrote: > > > Is there some specific reason you need timestamp seperate? If you're > > really up for that, why not just limit each ICMP type seperately? > > There's no real need for it to be separate, it ju

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Mike Silbersack
On Wed, 13 Dec 2000, Richard A. Steenbergen wrote: > > Hm, true. I was thinking of limiting the outgoing side, which would mean > > ipfw comes later in the string, but I suppose that if you limit on the > > incoming ipfw's sooner. > > Historically bandlim has been the process of stopping the

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Richard A. Steenbergen
On Wed, 13 Dec 2000, Mike Silbersack wrote: > On Wed, 13 Dec 2000, Richard A. Steenbergen wrote: > > > > Hm, true. I was thinking of limiting the outgoing side, which would mean > > > ipfw comes later in the string, but I suppose that if you limit on the > > > incoming ipfw's sooner. > > > > H

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Kirk McKusick
I believe that your changes have been sorely needed for many years. While I would like to see regular mbufs given a callback mechanism, your present approach of using an mbuf cluster solves 90% of the problem. Kirk McKusick To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscri

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Matt Dillon
:I believe that your changes have been sorely needed for many :years. While I would like to see regular mbufs given a callback :mechanism, your present approach of using an mbuf cluster :solves 90% of the problem. : : Kirk McKusick ... Aflred, be careful that you don't break things we

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Brian Somers
> Not a lot of people are familiar with fd passing so I'll give > a short description: > > By using AF_UNIX sockets between processes, a process can use > sendmsg() to send a filedescriptor through the socket where the > other process will do a recvmsg() to pickup the descriptor. > > The "

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Alfred Perlstein
* Matt Dillon <[EMAIL PROTECTED]> [001213 13:07] wrote: > :I believe that your changes have been sorely needed for many > :years. While I would like to see regular mbufs given a callback > :mechanism, your present approach of using an mbuf cluster > :solves 90% of the problem. > : > : Kirk Mc

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Alfred Perlstein
* Alfred Perlstein <[EMAIL PROTECTED]> [001213 14:20] wrote: > * Matt Dillon <[EMAIL PROTECTED]> [001213 13:07] wrote: > > :I believe that your changes have been sorely needed for many > > :years. While I would like to see regular mbufs given a callback > > :mechanism, your present approach of usi

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Bill Fumerola
On Wed, Dec 13, 2000 at 02:42:53PM -0500, Richard A. Steenbergen wrote: > It could just as easily be a SYN flood against a single port... or a large > number of clients trying to connected to your crashed web server... :P Or > it could just as easily be an ack flood against a port without a liste

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Tony Finch
Brian Somers <[EMAIL PROTECTED]> wrote: > >Hmm, the last time i looked at this, I believe the whole thing was >dealt with by not increasing the file descriptor reference count >when it was put in the message header. If process A closed the >descriptor before process B actually recvmsg()d it, i

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Alfred Perlstein
> This causes a leak, I think the trick is to just always call sorflush() > when the pcb is free'd. Even this doesn't work. > > Looking at linux they still are using gc. I'll give this a lot > more thought before resubmitting this idea. Ok, the problem is you have 3 af_unix pairs all open bet

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Bosko Milekic
On Wed, 13 Dec 2000, Bill Fumerola wrote: > On Wed, Dec 13, 2000 at 02:42:53PM -0500, Richard A. Steenbergen wrote: > > > It could just as easily be a SYN flood against a single port... or a large > > number of clients trying to connected to your crashed web server... :P Or > > it could just as

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Tony Finch
Alfred Perlstein <[EMAIL PROTECTED]> wrote: > >I guess the gc has to stay. > >dammit. :) > >My apologies for wasting everyone's time here. ``One day a student came to Moon and said: "I understand how to make a better garbage collector. We must keep a reference count of the pointers to each cons."

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Brian Somers
> Brian Somers <[EMAIL PROTECTED]> wrote: > > > >Hmm, the last time i looked at this, I believe the whole thing was > >dealt with by not increasing the file descriptor reference count > >when it was put in the message header. If process A closed the > >descriptor before process B actually recv

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Matt Dillon
:I guess the gc has to stay. : :dammit. :) : :My apologies for wasting everyone's time here. : :-- :-Alfred Perlstein - [[EMAIL PROTECTED]|[EMAIL PROTECTED]] No waste at all, Alfred, the file descriptor passing code had been broken for over 10 years precisely because of its complexity.

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Alfred Perlstein
* Matt Dillon <[EMAIL PROTECTED]> [001213 17:25] wrote: > > :I guess the gc has to stay. > : > :dammit. :) > : > :My apologies for wasting everyone's time here. > : > :-- > :-Alfred Perlstein - [[EMAIL PROTECTED]|[EMAIL PROTECTED]] > > No waste at all, Alfred, the file descriptor passing co

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Matt Dillon
:> No waste at all, Alfred, the file descriptor passing code had been : :Are you saying the code in place is broken? If so I'll spend some :time looking at it and the Linux implementation to figure if at :least one of us gets it right and try to find some sort of solution. No, *had*, no

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Matt Dillon
:Hmm, the last time i looked at this, I believe the whole thing was :dealt with by not increasing the file descriptor reference count :when it was put in the message header. If process A closed the :descriptor before process B actually recvmsg()d it, it would be :EBADF. The recvmsg() actual

Re: patch to cleanup inflight desciptor handling.

2000-12-13 Thread Tony Finch
Matt Dillon <[EMAIL PROTECTED]> wrote: > >No waste at all, Alfred, the file descriptor passing code had been >broken for over 10 years precisely because of its complexity. Rewriting >the GC to be more efficient essentially requires using deep graph theory >to locate isolated loops

Re: Ratelimint Enhancement patch (Please Review One Last Time!)

2000-12-13 Thread Bill Fumerola
On Wed, Dec 13, 2000 at 09:35:40PM -0500, Bosko Milekic wrote: > > Bosko, please change the descriptions to something very generic before > > committing them ("ratelimiting TCP RST packets: x/y pps" or something) > > Mike said he would do it and re-post the diff. Excellent. -- Bill Fume