Re: turning off TCP_NOPUSH

2003-05-29 Thread Garrett Wollman
< said: > As I understand if the data in the send buffer is bigger than MSS it means > that TCP stack has some reason not to send it and this reason is not > TF_NOPUSH flag. Am I wrong ? If TCP is for some reason prohibited from sending (i.e., the flow control or congestion control is closed), t

Re: turning off TCP_NOPUSH

2003-05-29 Thread Igor Sysoev
On Wed, 28 May 2003, Garrett Wollman wrote: > < said: > > > always calls tcp_output() when TCP_NOPUSH is turned off. I think > > tcp_output() should be called only if data in the send buffer is less > > than MSS: > > I believe that this is intentional. The application had to explicitly > enabl

turning off TCP_NOPUSH

2003-05-29 Thread Garrett Wollman
< said: > always calls tcp_output() when TCP_NOPUSH is turned off. I think > tcp_output() should be called only if data in the send buffer is less > than MSS: I believe that this is intentional. The application had to explicitly enable TCP_NOPUSH, so if the application disables it explicitly, t

turning off TCP_NOPUSH

2003-05-28 Thread Igor Sysoev
The 1.53 fix http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_usrreq.c.diff?r1=1.52&r2=1.53 always calls tcp_output() when TCP_NOPUSH is turned off. I think tcp_output() should be called only if data in the send buffer is less than MSS: tp->t_flags &= ~TF_NOPUSH; - error