Re: tcp_detach can return with inpcb lock held

2012-01-06 Thread John Baldwin
On Friday, January 06, 2012 6:22:25 am Robert Watson wrote: > > On Thu, 5 Jan 2012, Navdeep Parhar wrote: > > > Looks like there's a case where tcp_detach could return with the inp lock > > held. I see an XXXRW comment questioning this possibility, but we should > > either add an assertion to

Re: tcp_detach can return with inpcb lock held

2012-01-06 Thread Robert Watson
On Thu, 5 Jan 2012, Navdeep Parhar wrote: Looks like there's a case where tcp_detach could return with the inp lock held. I see an XXXRW comment questioning this possibility, but we should either add an assertion to verify that the case does not occur, or unlock the inpcb before returning.

tcp_detach can return with inpcb lock held

2012-01-05 Thread Navdeep Parhar
Looks like there's a case where tcp_detach could return with the inp lock held. I see an XXXRW comment questioning this possibility, but we should either add an assertion to verify that the case does not occur, or unlock the inpcb before returning. Or maybe both? Regards, Navdeep diff -r 35bdf8