Re: review of minor clarifying comments

2001-10-02 Thread Matthew N. Dodd
On Tue, 2 Oct 2001, Garrett Wollman wrote: > < said: > > > can be changed to: > > > mii = device_get_softc(dev); > > ifp = mii->mii_ifp; > > I don't see anything wrong with the way things are. Perhaps some more > documentation is necessary, but as noted upthread this has a 20-year > hi

Re: review of minor clarifying comments

2001-10-02 Thread Garrett Wollman
< said: > can be changed to: > mii = device_get_softc(dev); > ifp = mii->mii_ifp; I don't see anything wrong with the way things are. Perhaps some more documentation is necessary, but as noted upthread this has a 20-year history in the BSD networking stack and it's not like it's a

Re: review of minor clarifying comments

2001-10-02 Thread Matthew Jacob
On Tue, 2 Oct 2001, Matthew N. Dodd wrote: > On Mon, 1 Oct 2001, Matthew Jacob wrote: > > Yes- this may have been true for a long time - but quite a number of > > Unix variants don't require it, so I forgot :-).. For example, neither > > OpenBSD nor NetBSD seem to require it. > > > > It turns o

Re: review of minor clarifying comments

2001-10-02 Thread Matthew N. Dodd
On Mon, 1 Oct 2001, Matthew Jacob wrote: > Yes- this may have been true for a long time - but quite a number of > Unix variants don't require it, so I forgot :-).. For example, neither > OpenBSD nor NetBSD seem to require it. > > It turns out that this is only stumbled on rarely- but if it's all

Re: review of minor clarifying comments

2001-10-01 Thread Julian Elischer
On Mon, 1 Oct 2001, Garrett Wollman wrote: > < said: > > > +/* > > + * NB: For FreeBSD, it is assumed that each NIC driver's softc starts with > > + * one of these structures, typically held within an arpcom structure. > > + */ > > This has been true since at least 4.2. from my memory, I'ts

Re: review of minor clarifying comments

2001-10-01 Thread Matthew Jacob
Yes- this may have been true for a long time - but quite a number of Unix variants don't require it, so I forgot :-).. For example, neither OpenBSD nor NetBSD seem to require it. It turns out that this is only stumbled on rarely- but if it's all the same to you, a comment would help a lot. -mat

RE: review of minor clarifying comments

2001-10-01 Thread Matthew Jacob
gt; > -Original Message- > From: Matthew Jacob [mailto:[EMAIL PROTECTED]] > Sent: Monday, October 01, 2001 4:05 PM > To: [EMAIL PROTECTED] > Subject: review of minor clarifying comments > > > > This bit me in the butt yet again about FreeBSD and some assumptions abo

review of minor clarifying comments

2001-10-01 Thread Garrett Wollman
< This has been true since at least 4.2. Oops -- this is going to be the source of a lot of confusion. By 4.2 I am referring to 4.2BSD, of course, and not FreeBSD 4.2 which would not be much of a precedent. -GAWollman To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-ne

Re: review of minor clarifying comments

2001-10-01 Thread Julian Elischer
Not only that but the ifnet structure must be the first part of the arpcom struct so that arpcm, ifnet and softc often need to be the same.. I've been gradually trying to remove this requirement over the last 10 years but it's still there.. :-/ Comments can't hurt though.. On Mon, 1 Oct 2001, M

RE: review of minor clarifying comments

2001-10-01 Thread Jim McGrath
I ran into this same problem with the wx driver and submitted a pr. http://www.freebsd.org/cgi/query-pr.cgi?pr=29249 Jim -Original Message- From: Matthew Jacob [mailto:[EMAIL PROTECTED]] Sent: Monday, October 01, 2001 4:05 PM To: [EMAIL PROTECTED] Subject: review of minor clarifying

review of minor clarifying comments

2001-10-01 Thread Garrett Wollman
< said: > +/* > + * NB: For FreeBSD, it is assumed that each NIC driver's softc starts with > + * one of these structures, typically held within an arpcom structure. > + */ This has been true since at least 4.2. -GAWollman To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freeb

review of minor clarifying comments

2001-10-01 Thread Matthew Jacob
This bit me in the butt yet again about FreeBSD and some assumptions about how a NIC's softc is laid out- I don't really it stated elsewhere, so a couple source file comments seem in order.. Frankly, this kind of assumption is dangerous and unnecessary with methods, but at the very least it ought