Re: rev. 1.94 of netinet/in.c broke CARP

2007-01-29 Thread Bruce M. Simpson
Hello, I've had a chance to read ip_carp.c in more detail now, so... Gleb Smirnoff wrote: Is adding a generic GC function a correct way or was it better to just fix the buggy layer, that forgot about its multicast memberships? In the bigger picture: The real fix for netinet is to do what net

Re: rev. 1.94 of netinet/in.c broke CARP

2007-01-26 Thread Gleb Smirnoff
On Thu, Jan 25, 2007 at 10:00:08PM +, Robert Watson wrote: R> >On Thu, Jan 25, 2007 at 08:40:52PM +, Robert Watson wrote: R> >R> Architecturally, the right fix is that CARP needs to have a handler for R> >R> ifnet destruction that always runs before the multicast address garbage R> >R> coll

Re: rev. 1.94 of netinet/in.c broke CARP

2007-01-25 Thread Robert Watson
On Fri, 26 Jan 2007, Gleb Smirnoff wrote: On Thu, Jan 25, 2007 at 08:40:52PM +, Robert Watson wrote: R> Architecturally, the right fix is that CARP needs to have a handler for R> ifnet destruction that always runs before the multicast address garbage R> collection. I'm pretty preoccupied fo

Re: rev. 1.94 of netinet/in.c broke CARP

2007-01-25 Thread Max Laier
On Thursday 25 January 2007 22:23, Gleb Smirnoff wrote: > On Thu, Jan 25, 2007 at 08:40:52PM +, Robert Watson wrote: > R> Architecturally, the right fix is that CARP needs to have a handler > for R> ifnet destruction that always runs before the multicast address > garbage R> collection. I'm pre

Re: rev. 1.94 of netinet/in.c broke CARP

2007-01-25 Thread Gleb Smirnoff
On Thu, Jan 25, 2007 at 08:40:52PM +, Robert Watson wrote: R> Architecturally, the right fix is that CARP needs to have a handler for R> ifnet destruction that always runs before the multicast address garbage R> collection. I'm pretty preoccupied for the next few days due to an R> impending

Re: rev. 1.94 of netinet/in.c broke CARP

2007-01-25 Thread Robert Watson
On Thu, 25 Jan 2007, Gleb Smirnoff wrote: B> > Before this change, most of the subsystems, that allocated multicast B> >membership instances had freed is theirselves. I don't know about others, B> >but at least CARP is broken now. It attempts to free a memory, that B> >already has been freed. B

Re: rev. 1.94 of netinet/in.c broke CARP

2007-01-25 Thread Gleb Smirnoff
Bruce, On Thu, Jan 25, 2007 at 05:38:43PM +, Bruce M. Simpson wrote: B> Gleb Smirnoff wrote: B> > I've just discovered, that revision 1.94 of in.c has broke CARP. This B> >change adds a code to in_ifdetach() that goes through the global list B> >of all multicast instances and deletes all th

Re: rev. 1.94 of netinet/in.c broke CARP

2007-01-25 Thread Bruce M. Simpson
Gleb, Good catch, thanks for tracking this down. Gleb Smirnoff wrote: I've just discovered, that revision 1.94 of in.c has broke CARP. This change adds a code to in_ifdetach() that goes through the global list of all multicast instances and deletes all the instances, that are belonging to a p

rev. 1.94 of netinet/in.c broke CARP

2007-01-25 Thread Gleb Smirnoff
Hello, colleagues! I've just discovered, that revision 1.94 of in.c has broke CARP. This change adds a code to in_ifdetach() that goes through the global list of all multicast instances and deletes all the instances, that are belonging to a particular interface. This is intended to avoid leaki