Re: ng_ether naming

2013-01-28 Thread Gleb Smirnoff
On Sun, Jan 27, 2013 at 01:16:53PM +0200, Andriy Gapon wrote: A> based on your suggestions and submissions I've produced the following patch: A> http://people.freebsd.org/~avg/ng_ether-renaming.diff A> A> It's only compile-tested at the moment :) A> but I'd like to get your opinion about the direc

Re: ng_ether naming

2013-01-27 Thread Ermal Luçi
Hello, it looks good, for just interface renaming scope. The problem of it is that you need to check if the ifnet pointer needs updated as well. For coming and going interfaces like vlans you would have to update some pointers as well at least the ifnet one. The complete patch would rather inclu

Re: ng_ether naming

2013-01-27 Thread Andriy Gapon
Guys, based on your suggestions and submissions I've produced the following patch: http://people.freebsd.org/~avg/ng_ether-renaming.diff It's only compile-tested at the moment :) but I'd like to get your opinion about the direction of the change(s). I am going to really test the change very soon

Re: ng_ether naming

2012-12-14 Thread Nikolay Denev
face of interface renaming capability. Especially given that >>>> interface >>>> renaming and ng_ether _module_ loading may happen in an arbitrary order. >>>> >>>> I am not sure how to solve this best. >>>> >>>> One possibil

Re: ng_ether naming

2012-12-14 Thread Andriy Gapon
> >> renaming and ng_ether _module_ loading may happen in an arbitrary > order. > >> > >> I am not sure how to solve this best. > >> > >> One possibility is to use if_dname+if_dunit combination for ng_ether > naming. This >

Re: ng_ether naming

2012-12-13 Thread Ermal Luçi
is best. > >> > >> One possibility is to use if_dname+if_dunit combination for ng_ether > naming. This > >> should be stable and available for querying. This behavior should also > be > >> backward compatible with ng_ether being compiled into kernel > (if_dnam

Re: ng_ether naming

2012-12-13 Thread Andriy Gapon
of interface renaming capability. Especially given that >> interface >> renaming and ng_ether _module_ loading may happen in an arbitrary order. >> >> I am not sure how to solve this best. >> >> One possibility is to use if_dname+if_dunit combination for ng_e

Re: ng_ether naming

2012-12-13 Thread Alexander V. Chernikov
happen in an arbitrary order. I am not sure how to solve this best. One possibility is to use if_dname+if_dunit combination for ng_ether naming. This should be stable and available for querying. This behavior should also be backward compatible with ng_ether being compiled into kernel (if_dname

ng_ether naming

2012-12-13 Thread Andriy Gapon
how to solve this best. One possibility is to use if_dname+if_dunit combination for ng_ether naming. This should be stable and available for querying. This behavior should also be backward compatible with ng_ether being compiled into kernel (if_dname+if_dunit == if_xname before any renaming