Re: kern/61215: off-by-one error likely in ip_fragment()

2004-01-15 Thread David Gilbert
> "Andre" == Andre Oppermann <[EMAIL PROTECTED]> writes: Andre> Ok, I am asking you to check out if it works for you the same Andre> way it works for me. Then we can proceed to the next step and Andre> try to find out why it is different than it used to be for you. Well... I did ask what lin

Re: kern/61215: off-by-one error likely in ip_fragment()

2004-01-15 Thread Andre Oppermann
David Gilbert wrote: > > > "Andre" == Andre Oppermann <[EMAIL PROTECTED]> writes: > > Andre> Where are the outer addresses? > > 24.100.27.151 to 66.246.133.17. As I said... the above was the older > output ... which is the same save printing the tunnel endpoints. > > Andre> It should look

Re: kern/61215: off-by-one error likely in ip_fragment()

2004-01-15 Thread David Gilbert
> "Andre" == Andre Oppermann <[EMAIL PROTECTED]> writes: Andre> Where are the outer addresses? 24.100.27.151 to 66.246.133.17. As I said... the above was the older output ... which is the same save printing the tunnel endpoints. Andre> It should look like this (at least I was able to get co

Re: kern/61215: off-by-one error likely in ip_fragment()

2004-01-15 Thread Andre Oppermann
David Gilbert wrote: > > > "Andre" == Andre Oppermann <[EMAIL PROTECTED]> writes: > > >> I'm not sure what's up. Your patch wouldn't apply to v1.17 of my > >> if_gre.c, so something's wrong with the patch. Regardless, I > >> applied the patch by hand and things didn't work yet. > > Andre>

Re: kern/61215: off-by-one error likely in ip_fragment()

2004-01-15 Thread David Gilbert
> "Andre" == Andre Oppermann <[EMAIL PROTECTED]> writes: >> I'm not sure what's up. Your patch wouldn't apply to v1.17 of my >> if_gre.c, so something's wrong with the patch. Regardless, I >> applied the patch by hand and things didn't work yet. Andre> Didn't it apply because of patch comp

Re: kern/61215: off-by-one error likely in ip_fragment()

2004-01-15 Thread Andre Oppermann
David Gilbert wrote: > > > "Andre" == Andre Oppermann <[EMAIL PROTECTED]> writes: > > Andre> David, the problem with if_gre is actually twofold: > > Andre> - the change of htons(m->m_pkthdr.len) in the last commit to > Andre> that file is incorrect. In FreeBSD this is done in ip_output >

Re: kern/61215: off-by-one error likely in ip_fragment()

2004-01-15 Thread David Gilbert
> "Andre" == Andre Oppermann <[EMAIL PROTECTED]> writes: Andre> David, the problem with if_gre is actually twofold: Andre> - the change of htons(m->m_pkthdr.len) in the last commit to Andre> that file is incorrect. In FreeBSD this is done in ip_output Andre> for all packets sent (unless RA

Re: kern/61215: off-by-one error likely in ip_fragment()

2004-01-14 Thread Andre Oppermann
David, the problem with if_gre is actually twofold: - the change of htons(m->m_pkthdr.len) in the last commit to that file is incorrect. In FreeBSD this is done in ip_output for all packets sent (unless RAW). - The struct ip which is contained in struct gh is not correctly intialized.