Re: if_link_state_change() patch for review

2005-04-20 Thread Sam Leffler
Gleb Smirnoff wrote: On Tue, Apr 19, 2005 at 08:27:19AM -0700, Sam Leffler wrote: S> >change message will report either all state changes or those where at S> >the time of reporting the state changed relative to the last report. S> >The same assumption is true for the OpenIGPd we are working on at

Re: if_link_state_change() patch for review

2005-04-19 Thread Gleb Smirnoff
On Tue, Apr 19, 2005 at 08:27:19AM -0700, Sam Leffler wrote: S> >change message will report either all state changes or those where at S> >the time of reporting the state changed relative to the last report. S> >The same assumption is true for the OpenIGPd we are working on at the S> >moment. S> S>

Re: if_link_state_change() patch for review

2005-04-19 Thread Sam Leffler
Andre Oppermann wrote: Gleb Smirnoff wrote: On Tue, Apr 19, 2005 at 02:08:28PM +0200, Andre Oppermann wrote: A> Gleb Smirnoff wrote: A> > A> You have to be careful here indeed. If the link is rapidly flapping A> > A> then you only want to report changes in status. For example when A> > A> it goin

Re: if_link_state_change() patch for review

2005-04-19 Thread Andre Oppermann
Gleb Smirnoff wrote: > > On Tue, Apr 19, 2005 at 02:08:28PM +0200, Andre Oppermann wrote: > A> Gleb Smirnoff wrote: > A> > A> You have to be careful here indeed. If the link is rapidly flapping > A> > A> then you only want to report changes in status. For example when > A> > A> it going down, up

Re: if_link_state_change() patch for review

2005-04-19 Thread Gleb Smirnoff
On Tue, Apr 19, 2005 at 02:08:28PM +0200, Andre Oppermann wrote: A> Gleb Smirnoff wrote: A> > A> You have to be careful here indeed. If the link is rapidly flapping A> > A> then you only want to report changes in status. For example when A> > A> it going down, up, down and all these events got qu

Re: if_link_state_change() patch for review

2005-04-19 Thread Andre Oppermann
Gleb Smirnoff wrote: > A> You have to be careful here indeed. If the link is rapidly flapping > A> then you only want to report changes in status. For example when > A> it going down, up, down and all these events got queued it doesn't > A> make sense to report down->down. This could indeed conf

Re: if_link_state_change() patch for review

2005-04-19 Thread Gleb Smirnoff
Andre, On Tue, Apr 19, 2005 at 11:49:36AM +0200, Andre Oppermann wrote: A> > we are working on fixing LORs in if_link_state_change() path, and A> > adding possibility to call if_link_state_change() pseudorecursively, A> > when link of interface depends on link of the other. A> > A> > I'm postin

Re: if_link_state_change() patch for review

2005-04-19 Thread Andre Oppermann
Gleb Smirnoff wrote: > > Dear networkers, > > we are working on fixing LORs in if_link_state_change() path, and > adding possibility to call if_link_state_change() pseudorecursively, > when link of interface depends on link of the other. > > I'm posting this patch for wider review. An importan

if_link_state_change() patch for review

2005-04-18 Thread Gleb Smirnoff
Dear networkers, we are working on fixing LORs in if_link_state_change() path, and adding possibility to call if_link_state_change() pseudorecursively, when link of interface depends on link of the other. I'm posting this patch for wider review. An important point about it is that, if several l