Re: bpf hold buffer in-use flag

2013-05-23 Thread John Baldwin
On Thursday, May 23, 2013 5:05:39 pm Guy Helmer wrote: > > On Jan 9, 2013, at 2:35 PM, John Baldwin wrote: > > > On Tuesday, November 13, 2012 4:40:57 pm Guy Helmer wrote: > >> To try to completely resolve the race in bpfread(), I have put together > > these changes to add a flag to indicate wh

Re: bpf hold buffer in-use flag

2013-05-23 Thread Guy Helmer
On Jan 9, 2013, at 2:35 PM, John Baldwin wrote: > On Tuesday, November 13, 2012 4:40:57 pm Guy Helmer wrote: >> To try to completely resolve the race in bpfread(), I have put together > these changes to add a flag to indicate when the hold buffer cannot be > modified because it is in use. Sinc

Re: bpf hold buffer in-use flag

2013-01-13 Thread Guy Helmer
On Jan 11, 2013, at 5:48 PM, Christian Peron wrote: > Guy, > > Can you please describe the race and how to reproduce it? When we introduced > zerocopy-bpf, we also introduced bpf_bufheld() and bpf_bufreclaimed() which > are effectively nops for the regular buffer mode. Maybe we could maintain

Re: bpf hold buffer in-use flag

2013-01-11 Thread Christian Peron
I meant "nops" for the regular buffer mode… On 2013-01-11, at 5:48 PM, Christian Peron wrote: > Guy, > > Can you please describe the race and how to reproduce it? When we introduced > zerocopy-bpf, we also introduced bpf_bufheld() and bpf_bufreclaimed() which > are effectively hops for the reg

Re: bpf hold buffer in-use flag

2013-01-11 Thread Christian Peron
Guy, Can you please describe the race and how to reproduce it? When we introduced zerocopy-bpf, we also introduced bpf_bufheld() and bpf_bufreclaimed() which are effectively hops for the regular buffer mode. Maybe we could maintain state there as well? In any case, I would like to understand th

Re: bpf hold buffer in-use flag

2013-01-09 Thread John Baldwin
On Tuesday, November 13, 2012 4:40:57 pm Guy Helmer wrote: > To try to completely resolve the race in bpfread(), I have put together these changes to add a flag to indicate when the hold buffer cannot be modified because it is in use. Since it's my first time using mtx_sleep() and wakeup(), I wa

bpf hold buffer in-use flag

2012-11-13 Thread Guy Helmer
To try to completely resolve the race in bpfread(), I have put together these changes to add a flag to indicate when the hold buffer cannot be modified because it is in use. Since it's my first time using mtx_sleep() and wakeup(), I wanted to run these past the list to see if I can get any feedb