Re: Strange logic in r336438

2020-01-17 Thread Hans Petter Selasky
On 2020-01-17 00:31, Eric van Gyzen wrote: I was just reviewing r336438: https://svnweb.freebsd.org/base?view=revision&revision=336438 In bxe_interrupt_detach(), the nested loops over sc->num_queues don't look right.  We drain the taskqueues for queue 0, but then free the taskqueues for queue

Strange logic in r336438

2020-01-16 Thread Eric van Gyzen
I was just reviewing r336438: https://svnweb.freebsd.org/base?view=revision&revision=336438 In bxe_interrupt_detach(), the nested loops over sc->num_queues don't look right. We drain the taskqueues for queue 0, but then free the taskqueues for queues 1-N without draining them. Should the sec