Re: SCTP, possible bug in peer authentication key

2009-02-09 Thread Randall Stewart
Note that all of these changes are now in Head.. however I am not sure of the likely-hood of them moving into 7 since the xsctp_ changes for the mib (rwnd and assoc_id) break ABI compatability. I have now (in head) padded up the structures at the end (in case we need to add more). But in gene

Re: SCTP, possible bug in peer authentication key

2009-01-30 Thread Michael Tüxen
[mailto:michael.tue...@lurchi.franken.de] Sent: Thursday, 29 January 2009 6:23 PM To: Yann WANWANSCAPPEL Cc: freebsd-net@freebsd.org Subject: Re: SCTP, possible bug in peer authentication key Hi Yann, very good catch! You are right. I have committed your patch to Randalls repository, so it will show

RE: SCTP, possible bug in peer authentication key

2009-01-29 Thread Muggeridge, Matt
ichael Tüxen [mailto:michael.tue...@lurchi.franken.de] Sent: Thursday, 29 January 2009 6:23 PM To: Yann WANWANSCAPPEL Cc: freebsd-net@freebsd.org Subject: Re: SCTP, possible bug in peer authentication key Hi Yann, very good catch! You are right. I have committed your patch to Randalls reposito

Re: SCTP, possible bug in peer authentication key

2009-01-29 Thread Michael Tüxen
Hi Peter, good catch! Best regards Michael On Jan 29, 2009, at 6:29 PM, Peter Lei wrote: There's a corresponding change that is needed for pulling the auth info out of the cookie for the other direction (i.e. server side handling). I've committed that into the SCTP project repo, and sho

Re: SCTP, possible bug in peer authentication key

2009-01-29 Thread Peter Lei
There's a corresponding change that is needed for pulling the auth info out of the cookie for the other direction (i.e. server side handling). I've committed that into the SCTP project repo, and should also get in with Randall's next commit. --peter On Jan 29, 2009, at 2:23 AM, Michael Tüxe

Re: SCTP, possible bug in peer authentication key

2009-01-29 Thread Michael Tüxen
Hi Yann, very good catch! You are right. I have committed your patch to Randalls repository, so it will show up in the FreeBSD sources soon (next time he syncs them)... Best regards Michael On Jan 28, 2009, at 8:51 PM, Yann WANWANSCAPPEL wrote: Hi all, I think I found a bug in the SCTP auth

SCTP, possible bug in peer authentication key

2009-01-28 Thread Yann WANWANSCAPPEL
Hi all, I think I found a bug in the SCTP authentication code, in sctp_load_addresses_from_init() in sctp_pcb.c keylen = sizeof(*p_random) + random_len + sizeof(*chunks) + num_chunks + sizeof(*hmacs) + hmacs_len; The keylen calculation assumes the Chunk List Parameter (CHUNKS) vl-param was prese