Re: tcp_output() might generate invalid TSO frames

2009-04-16 Thread Andre Oppermann
Renaud Lienhart wrote: Hi, We're having trouble virtualizing FreeBSD 7+ on ESX because of an issue with the stack's TSO implementation: it sometimes generates TSO packets whose payload size is actually smaller than the MSS. The faulty logic is described, along with a patch, in PR #132832. It ha

Re: tcp_output() might generate invalid TSO frames

2009-04-15 Thread Jack Vogel
No, the problem Mike is having is due to an issue in our new shared code in how we get the mac address, we changed it to support alt mac addresses, and it works find on our hardware, there is an issue in the vmware emulation. Nevertheless, if there's a problem in the TSO code it would be nice to g

Re: tcp_output() might generate invalid TSO frames

2009-04-15 Thread Kip Macy
Interesting. That might explain a problem that Mike Silbersack is seeing with the latest em driver on vmware. I don't know of any NICs that actually choke on such frames. Nonetheless, it is silly behavior. I'll try to see if we can get this fixed before 7.2. Thanks, Kip On Wed, Apr 15, 2009 at 8