Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-06 Thread Andre Oppermann
On 06.11.2012 09:27, Adrian Chadd wrote: Hiya, On 2 November 2012 05:38, Gleb Smirnoff wrote: Hello networkers, some (most) of m_flags bits are describing features that can be present on a packet only, not on a single mbuf. Since we are close to exhaustion of available bits, and many su

Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-06 Thread Adrian Chadd
Hiya, On 2 November 2012 05:38, Gleb Smirnoff wrote: > Hello networkers, > > some (most) of m_flags bits are describing features that can > be present on a packet only, not on a single mbuf. Since we are > close to exhaustion of available bits, and many subsystems prefer > to use one of M_PRO

Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-03 Thread Gleb Smirnoff
On Fri, Nov 02, 2012 at 01:54:50PM +0100, Andre Oppermann wrote: A> > An attentive reader may have noticed that I missed M_NOFREE and M_FREELIST. A> > Yep, these flags coming from historical mbuf allocator from FreeBSD 4.x times A> > are about to be deleted, we carefully examine them, but never se

Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-02 Thread Andre Oppermann
On 02.11.2012 18:18, Luigi Rizzo wrote: On Fri, Nov 02, 2012 at 09:12:23AM -0700, Juli Mallett wrote: On Fri, Nov 2, 2012 at 5:54 AM, Andre Oppermann wrote: On 02.11.2012 13:38, Gleb Smirnoff wrote: #define M_SKIP_FIREWALL 0x4000 /* skip firewall processing */ This one should become a

Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-02 Thread Luigi Rizzo
On Fri, Nov 02, 2012 at 09:12:23AM -0700, Juli Mallett wrote: > On Fri, Nov 2, 2012 at 5:54 AM, Andre Oppermann wrote: > > > On 02.11.2012 13:38, Gleb Smirnoff wrote: > > > >> #define M_SKIP_FIREWALL 0x4000 /* skip firewall processing */ > >> > > > > This one should become an M_PROTO overlay.

Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-02 Thread Juli Mallett
On Fri, Nov 2, 2012 at 5:54 AM, Andre Oppermann wrote: > On 02.11.2012 13:38, Gleb Smirnoff wrote: > >> #define M_SKIP_FIREWALL 0x4000 /* skip firewall processing */ >> > > This one should become an M_PROTO overlay. It is only relevant within > a protocol layer. No, like M_PROMISC it needs

Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-02 Thread Andre Oppermann
On 02.11.2012 13:38, Gleb Smirnoff wrote: Hello networkers, some (most) of m_flags bits are describing features that can be present on a packet only, not on a single mbuf. Since we are close to exhaustion of available bits, and many subsystems prefer to use one of M_PROTO bits instead of g