On Tue, 2 Oct 2001, Garrett Wollman wrote:
> < said:
>
> > can be changed to:
>
> > mii = device_get_softc(dev);
> > ifp = mii->mii_ifp;
>
> I don't see anything wrong with the way things are. Perhaps some more
> documentation is necessary, but as noted upthread this has a 20-year
> hi
< said:
> can be changed to:
> mii = device_get_softc(dev);
> ifp = mii->mii_ifp;
I don't see anything wrong with the way things are. Perhaps some more
documentation is necessary, but as noted upthread this has a 20-year
history in the BSD networking stack and it's not like it's a
On Tue, 2 Oct 2001, Matthew N. Dodd wrote:
> On Mon, 1 Oct 2001, Matthew Jacob wrote:
> > Yes- this may have been true for a long time - but quite a number of
> > Unix variants don't require it, so I forgot :-).. For example, neither
> > OpenBSD nor NetBSD seem to require it.
> >
> > It turns o
On Mon, 1 Oct 2001, Matthew Jacob wrote:
> Yes- this may have been true for a long time - but quite a number of
> Unix variants don't require it, so I forgot :-).. For example, neither
> OpenBSD nor NetBSD seem to require it.
>
> It turns out that this is only stumbled on rarely- but if it's all
On Mon, 1 Oct 2001, Garrett Wollman wrote:
> < said:
>
> > +/*
> > + * NB: For FreeBSD, it is assumed that each NIC driver's softc starts with
> > + * one of these structures, typically held within an arpcom structure.
> > + */
>
> This has been true since at least 4.2.
from my memory, I'ts
Yes- this may have been true for a long time - but quite a number of Unix
variants don't require it, so I forgot :-).. For example, neither OpenBSD nor
NetBSD seem to require it.
It turns out that this is only stumbled on rarely- but if it's all the same to
you, a comment would help a lot.
-mat
Huh. Too bad you didn't point me at the bug- it would have saved me a
morning's debugging.
On Mon, 1 Oct 2001, Jim McGrath wrote:
> I ran into this same problem with the wx driver and submitted a pr.
> http://www.freebsd.org/cgi/query-pr.cgi?pr=29249
>
> Jim
>
>
> -Original Message-
Not only that but the ifnet structure must be the first part of the arpcom
struct so that arpcm, ifnet and softc often need to be the same.. I've
been gradually trying to remove this requirement over the last 10 years
but it's still there.. :-/
Comments can't hurt though..
On Mon, 1 Oct 2001, M
I ran into this same problem with the wx driver and submitted a pr.
http://www.freebsd.org/cgi/query-pr.cgi?pr=29249
Jim
-Original Message-
From: Matthew Jacob [mailto:[EMAIL PROTECTED]]
Sent: Monday, October 01, 2001 4:05 PM
To: [EMAIL PROTECTED]
Subject: review of minor clarifying com