Re: ng_ether naming

2013-01-28 Thread Gleb Smirnoff
On Sun, Jan 27, 2013 at 01:16:53PM +0200, Andriy Gapon wrote: A> based on your suggestions and submissions I've produced the following patch: A> http://people.freebsd.org/~avg/ng_ether-renaming.diff A> A> It's only compile-tested at the moment :) A> but I'd like to get your opinion about the direc

Re: ng_ether naming

2013-01-27 Thread Ermal Luçi
Hello, it looks good, for just interface renaming scope. The problem of it is that you need to check if the ifnet pointer needs updated as well. For coming and going interfaces like vlans you would have to update some pointers as well at least the ifnet one. The complete patch would rather inclu

Re: ng_ether naming

2013-01-27 Thread Andriy Gapon
Guys, based on your suggestions and submissions I've produced the following patch: http://people.freebsd.org/~avg/ng_ether-renaming.diff It's only compile-tested at the moment :) but I'd like to get your opinion about the direction of the change(s). I am going to really test the change very soon

Re: ng_ether naming

2012-12-14 Thread Nikolay Denev
On Dec 14, 2012, at 7:02 PM, Andriy Gapon wrote: > on 13/12/2012 20:57 Ermal Luçi said the following: >> >> >> >> On Thu, Dec 13, 2012 at 5:25 PM, Andriy Gapon > > wrote: >> >>on 13/12/2012 14:08 Alexander V. Chernikov said the following: >>> On 13.12.2012 15:46,

Re: ng_ether naming

2012-12-14 Thread Andriy Gapon
on 13/12/2012 20:57 Ermal Luçi said the following: > > > > On Thu, Dec 13, 2012 at 5:25 PM, Andriy Gapon > wrote: > > on 13/12/2012 14:08 Alexander V. Chernikov said the following: > > On 13.12.2012 15:46, Andriy Gapon wrote: > >> > >> ng_ether uses if_

Re: ng_ether naming

2012-12-13 Thread Ermal Luçi
On Thu, Dec 13, 2012 at 5:25 PM, Andriy Gapon wrote: > on 13/12/2012 14:08 Alexander V. Chernikov said the following: > > On 13.12.2012 15:46, Andriy Gapon wrote: > >> > >> ng_ether uses if_xname for naming its nodes. > >> This could be troublesome for mapping interface names to their ng_ether >

Re: ng_ether naming

2012-12-13 Thread Andriy Gapon
on 13/12/2012 14:08 Alexander V. Chernikov said the following: > On 13.12.2012 15:46, Andriy Gapon wrote: >> >> ng_ether uses if_xname for naming its nodes. >> This could be troublesome for mapping interface names to their ng_ether >> companions >> in the face of interface renaming capability. Es

Re: ng_ether naming

2012-12-13 Thread Alexander V. Chernikov
On 13.12.2012 15:46, Andriy Gapon wrote: ng_ether uses if_xname for naming its nodes. This could be troublesome for mapping interface names to their ng_ether companions in the face of interface renaming capability. Especially given that interface renaming and ng_ether _module_ loading may happ