Re: netmap/ixl and crc addition..

2020-03-26 Thread Vincenzo Maffione
Il giorno gio 26 mar 2020 alle ore 11:39 Alexandre Snarskii < s...@snar.spb.ru> ha scritto: > On Wed, Mar 25, 2020 at 11:31:30PM +0100, Vincenzo Maffione wrote: > > Hi Alexandre, > > Thanks. Your patch looks good to me. I assume you have tested it? > > Sure, this patch is already handles product

Re: netmap/ixl and crc addition..

2020-03-26 Thread Alexandre Snarskii
On Wed, Mar 25, 2020 at 11:31:30PM +0100, Vincenzo Maffione wrote: > Hi Alexandre, >   Thanks. Your patch looks good to me. I assume you have tested it? Sure, this patch is already handles production traffic. > I will commit that to stable/11. Thanks. > > The issue you report on stable/12 is m

Re: netmap/ixl and crc addition..

2020-03-25 Thread Slawa Olhovchenkov
On Wed, Mar 25, 2020 at 11:31:30PM +0100, Vincenzo Maffione wrote: > Hi Alexandre, > Thanks. Your patch looks good to me. I assume you have tested it? > I will commit that to stable/11. > > The issue you report on stable/12 is more worrisome. The 'no space in TX > ring' condition (head==cur==ta

Re: netmap/ixl and crc addition..

2020-03-25 Thread Vincenzo Maffione
Hi Alexandre, Thanks. Your patch looks good to me. I assume you have tested it? I will commit that to stable/11. The issue you report on stable/12 is more worrisome. The 'no space in TX ring' condition (head==cur==tail) is ok per-se: on a subsequent poll() wakeup (e.g. TX interrupt) or explicit

Re: netmap/ixl and crc addition..

2020-03-24 Thread Alexandre Snarskii
On Tue, Mar 24, 2020 at 03:37:36PM +0300, Alexandre Snarskii wrote: > > Hi! > > Long story short: looks like intel x722 does not by default add CRC to > outbound frames, so with FreeBSD 11-stable netmap-generated traffic is > dropped on the next port.. Fix is simple, attached. ... add missing