Re: last call for L2/L3 rewrite code review

2008-12-11 Thread Kip Macy
I think that you're request to not monopolize the AF_INET slot is reasonable. Do you intend to merge bms_netdev before 8 branches (I'm guessing this coming summer)? Cheers, Kip On Thu, Dec 11, 2008 at 10:18 AM, Bruce M. Simpson wrote: > Hi, > > Just skimming this I notice it uses the if_afdata[

Re: last call for L2/L3 rewrite code review

2008-12-11 Thread Bruce M. Simpson
Hi, Just skimming this I notice it uses the if_afdata[AF_INET] pointer purely for lltbl purposes; this clashes with the IGMPv3 code drop. Please look in the bms_netdev branch, where I introduce a 'struct ip_ifinfo' to make more general use of that slot. IGMPv3 needs to store per-interface st

Re: last call for L2/L3 rewrite code review

2008-12-10 Thread Marko Zec
On Wednesday 10 December 2008 10:30:35 Kip Macy wrote: > > The reason I am asking is that people are still seeing panics from > > the rnh locking and aren't even able to boot machines. > > I have not seen this. Please tell me where this occurs. I had a machine with defaultrouter from /etc/rc.conf

Re: last call for L2/L3 rewrite code review

2008-12-10 Thread Kip Macy
> The reason I am asking is that people are still seeing panics from > the rnh locking and aren't even able to boot machines. I have not seen this. Please tell me where this occurs. > Mixng route > locking bugs with this rewrite will be painful. As I hope that the > rnh bugs will be solved within

Re: last call for L2/L3 rewrite code review

2008-12-10 Thread Bjoern A. Zeeb
On Wed, 10 Dec 2008, Qing Li wrote: Hi, It's becoming increasingly difficult to maintain a separate branch (p4 or svn) due to the high volume of new features' related commits. The integration and unit testing efforts increase in complexity by the week. [..] I would like to commit the code w