Gleb,
Here is a patch based on my latest igb internal code, I had not yet
committed this as I
was not completely confident about the start/queueing changes, I would love
to have a
wider testing base, so anyone that wishes to test this... Its against HEAD.
It does a few things: change mq_start to
Hi Gleb,
On 21/11/2012 1:26 AM, Gleb Smirnoff wrote:
Jack,
On Tue, Nov 20, 2012 at 09:19:54AM -0800, Jack Vogel wrote:
J> > I'd suggest the following code:
J> >
J> > if (m)
J> > drbr_enqueue(ifp, txr->br, m);
J> > err = igb_mq_start_loc
Jack,
On Tue, Nov 20, 2012 at 09:19:54AM -0800, Jack Vogel wrote:
J> > I'd suggest the following code:
J> >
J> > if (m)
J> > drbr_enqueue(ifp, txr->br, m);
J> > err = igb_mq_start_locked(ifp, txr, NULL);
J> >
J> > Which eventually leads us
On Tue, Nov 20, 2012 at 3:18 AM, Gleb Smirnoff wrote:
> Karim,
>
> On Mon, Nov 19, 2012 at 02:57:24PM -0500, Karim Fodil-Lemelin wrote:
> K> While testing the latest igb driver in CURRENT I came across an issue
> K> with igb_mq_start(). More specifically this code:
> K>
> K> ...
> K>
> K>
Gleb,
On 20/11/2012 6:18 AM, Gleb Smirnoff wrote:
Karim,
On Mon, Nov 19, 2012 at 02:57:24PM -0500, Karim Fodil-Lemelin wrote:
K> While testing the latest igb driver in CURRENT I came across an issue
K> with igb_mq_start(). More specifically this code:
K>
K> ...
K>
K> struct mbuf *pm
Karim,
On Mon, Nov 19, 2012 at 02:57:24PM -0500, Karim Fodil-Lemelin wrote:
K> While testing the latest igb driver in CURRENT I came across an issue
K> with igb_mq_start(). More specifically this code:
K>
K> ...
K>
K> struct mbuf *pm = NULL;
K> /*
K> ** Try to queue
Indeed, I found this very same problem in internal testing, I took it out,
but then
have been working on the best way to keep the idea without the problems, I
have
code that will do that coming soon.
Thanks for the report!
Jack
On Mon, Nov 19, 2012 at 11:57 AM, Karim Fodil-Lemelin <
fodillemlin