Re: TSO broken with jumbo MTU

2011-10-20 Thread Ben Hutchings
On Tue, 2011-10-18 at 00:28 +0100, Ben Hutchings wrote: > On Mon, 2011-10-17 at 18:09 +0200, Andre Oppermann wrote: > > On 17.10.2011 17:29, Ben Hutchings wrote: > > > This is the fix/workaround I used: > > > > Thanks for the fix. I'll review it and put it into FreeBSD maybe in > > a slightly dif

Re: TSO broken with jumbo MTU

2011-10-19 Thread Ben Hutchings
On Mon, 2011-10-17 at 23:59 +, Bjoern A. Zeeb wrote: > On 17. Oct 2011, at 23:28 , Ben Hutchings wrote: > > > On Mon, 2011-10-17 at 18:09 +0200, Andre Oppermann wrote: > >> On 17.10.2011 17:29, Ben Hutchings wrote: > >>> This is the fix/workaround I used: > >> > >> Thanks for the fix. I'll r

Re: TSO broken with jumbo MTU

2011-10-17 Thread Bjoern A. Zeeb
On 17. Oct 2011, at 23:28 , Ben Hutchings wrote: > On Mon, 2011-10-17 at 18:09 +0200, Andre Oppermann wrote: >> On 17.10.2011 17:29, Ben Hutchings wrote: >>> This is the fix/workaround I used: >> >> Thanks for the fix. I'll review it and put it into FreeBSD maybe in >> a slightly different form

Re: TSO broken with jumbo MTU

2011-10-17 Thread Ben Hutchings
On Mon, 2011-10-17 at 18:09 +0200, Andre Oppermann wrote: > On 17.10.2011 17:29, Ben Hutchings wrote: > > This is the fix/workaround I used: > > Thanks for the fix. I'll review it and put it into FreeBSD maybe in > a slightly different form. Which one? One is tested but maybe not right; the oth

Re: TSO broken with jumbo MTU

2011-10-17 Thread Andre Oppermann
On 17.10.2011 17:29, Ben Hutchings wrote: This is the fix/workaround I used: Thanks for the fix. I'll review it and put it into FreeBSD maybe in a slightly different form. -- Andre --- a/netinet/tcp_output.c +++ b/netinet/tcp_output.c @@ -1062,9 +1062,7 @@ * The TCP pseudo header c

Re: TSO broken with jumbo MTU

2011-10-17 Thread Ben Hutchings
This is the fix/workaround I used: --- a/netinet/tcp_output.c +++ b/netinet/tcp_output.c @@ -1062,9 +1062,7 @@ * The TCP pseudo header checksum is always provided. * XXX: Fixme: This is currently not the case for IPv6. */ - if (tso) { - KASSERT(len >