On Mon, Oct 08, 2001 at 02:53:32PM -0400, Garrett Wollman wrote:
> < said:
>
> > Second, let's look at the handling of SIOCADDMULTI/SIOCDELMULTI.
> > There is code obviously taken from if_loop.c and used in some
> > drivers, which tries to do something with the third argument "data"
> > of the if
On Mon, 8 Oct 2001, Warner Losh wrote:
> In message <[EMAIL PROTECTED]> Yar Tikhiy writes:
> : First, the current implementation of the utility function
> : ether_ioctl(), which can do good job common to ethernet drivers,
> : won't indicate the situation when an ioctl command is unsupported
> : b
On Mon, Oct 08, 2001 at 09:03:54AM -0600, Warner Losh wrote:
> Actaully, it should return ENOTTY rather than EINVAL. ENOTTY means
> that the ioctl isn't understood. I've had to fix several drivers at
> work that didn't follow this convention due to ignorance on the part
> of the driver writer.
In message <[EMAIL PROTECTED]> Yar Tikhiy writes:
: First, the current implementation of the utility function
: ether_ioctl(), which can do good job common to ethernet drivers,
: won't indicate the situation when an ioctl command is unsupported
: by it. It will return 0 in this case. Wouldn't it b
