Re: A slight change to tcpip_fillheaders...

2010-06-04 Thread Bruce Evans
On Thu, 3 Jun 2010, George Neville-Neil wrote: For what it's worth I checked the assembly for both versions as well. The bzero version does not inline, as you said, and the original does do a move of 0 for each and every field, again on Nehalem with our default version of gcc. I think that for

Re: A slight change to tcpip_fillheaders...

2010-06-03 Thread George Neville-Neil
On Jun 3, 2010, at 04:45 , Bruce Evans wrote: > > On Wed, 2 Jun 2010, George Neville-Neil wrote: > >> A while back another src developer mentioned that he had gotten better >> performance by changing >> tcpip_fillheaders() in the following way: > > It's unlikely to make any significant or even

Re: A slight change to tcpip_fillheaders...

2010-06-03 Thread Bruce Evans
On Wed, 2 Jun 2010, George Neville-Neil wrote: A while back another src developer mentioned that he had gotten better performance by changing tcpip_fillheaders() in the following way: It's unlikely to make any significant or even measurable difference, but... I got apparent large (up to 20%)

Re: A slight change to tcpip_fillheaders...

2010-06-02 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010/06/02 15:09, George Neville-Neil wrote: > Howdy, > > A while back another src developer mentioned that he had gotten better > performance by changing > tcpip_fillheaders() in the following way: [...] > I have tried this change with NetPIPE