Re: [please review] TSO mbuf chain length limiting patch

2012-06-03 Thread Lawrence Stewart
On 06/04/12 13:33, Colin Percival wrote: On 06/03/12 20:14, Lawrence Stewart wrote: On 06/04/12 02:51, Colin Percival wrote: I've attached a new patch which: 1. adds a IFCAP_TSO_MSS "capability" and a if_tx_tso_mss field to struct ifnet, A minor thing, but I don't like the overloading of the

Re: [please review] TSO mbuf chain length limiting patch

2012-06-03 Thread Colin Percival
On 06/03/12 20:14, Lawrence Stewart wrote: > On 06/04/12 02:51, Colin Percival wrote: >> I've attached a new patch which: >> 1. adds a IFCAP_TSO_MSS "capability" and a if_tx_tso_mss field to struct >> ifnet, > > A minor thing, but I don't like the overloading of the term MSS. Perhaps > s/MSS/CHUN

Re: [please review] TSO mbuf chain length limiting patch

2012-06-03 Thread Lawrence Stewart
On 06/04/12 02:51, Colin Percival wrote: On 05/30/12 08:30, Andrew Gallatin wrote: On 05/30/12 10:59, Colin Percival wrote: The Xen virtual network interface has an issue (ok, really the issue is with the linux back-end, but that's what most people are using) where it can't handle scatter-gathe

Re: [please review] TSO mbuf chain length limiting patch

2012-06-03 Thread Colin Percival
On 06/03/12 15:56, Bjoern A. Zeeb wrote: > On 3. Jun 2012, at 16:51 , Colin Percival wrote: >> I've attached a new patch which: >> 1. adds a IFCAP_TSO_MSS "capability" and a if_tx_tso_mss field to struct >> ifnet, >> 2. sets these in netfront when the IFCAP_TSO4 flag is set, >> 3. extends tcp_maxm

Re: [please review] TSO mbuf chain length limiting patch

2012-06-03 Thread Bjoern A. Zeeb
On 3. Jun 2012, at 16:51 , Colin Percival wrote: > On 05/30/12 08:30, Andrew Gallatin wrote: >> On 05/30/12 10:59, Colin Percival wrote: >>> The Xen virtual network interface has an issue (ok, really the issue is with >>> the linux back-end, but that's what most people are using) where it can't >

Re: [please review] TSO mbuf chain length limiting patch

2012-06-03 Thread Colin Percival
On 06/03/12 12:05, Andrew Gallatin wrote: > On 06/03/12 12:51, Colin Percival wrote: >> I've attached a new patch which: >> 1. adds a IFCAP_TSO_MSS "capability" and a if_tx_tso_mss field to struct >> ifnet, >> 2. sets these in netfront when the IFCAP_TSO4 flag is set, >> 3. extends tcp_maxmtu to r

Re: [please review] TSO mbuf chain length limiting patch

2012-06-03 Thread Andrew Gallatin
On 06/03/12 12:51, Colin Percival wrote: On 05/30/12 08:30, Andrew Gallatin wrote: On 05/30/12 10:59, Colin Percival wrote: The Xen virtual network interface has an issue (ok, really the issue is with the linux back-end, but that's what most people are using) where it can't handle scatter-gathe

Re: [please review] TSO mbuf chain length limiting patch

2012-06-03 Thread Colin Percival
On 05/30/12 08:30, Andrew Gallatin wrote: > On 05/30/12 10:59, Colin Percival wrote: >> The Xen virtual network interface has an issue (ok, really the issue is with >> the linux back-end, but that's what most people are using) where it can't >> handle scatter-gather writes with lots of pieces, aka.

Re: [please review] TSO mbuf chain length limiting patch

2012-05-30 Thread Andrew Gallatin
On 05/30/12 18:35, Colin Percival wrote: On 05/30/12 08:30, Andrew Gallatin wrote: On 05/30/12 10:59, Colin Percival wrote: The Xen virtual network interface has an issue (ok, really the issue is with the linux back-end, but that's what most people are using) where it can't handle scatter-gathe

Re: [please review] TSO mbuf chain length limiting patch

2012-05-30 Thread Colin Percival
On 05/30/12 08:30, Andrew Gallatin wrote: > On 05/30/12 10:59, Colin Percival wrote: >> The Xen virtual network interface has an issue (ok, really the issue is with >> the linux back-end, but that's what most people are using) where it can't >> handle scatter-gather writes with lots of pieces, aka.

Re: [please review] TSO mbuf chain length limiting patch

2012-05-30 Thread Jack Vogel
On Wed, May 30, 2012 at 8:30 AM, Andrew Gallatin wrote: > On 05/30/12 10:59, Colin Percival wrote: > >> Hi all, >> >> The Xen virtual network interface has an issue (ok, really the issue is >> with >> the linux back-end, but that's what most people are using) where it can't >> handle scatter-gathe

Re: [please review] TSO mbuf chain length limiting patch

2012-05-30 Thread Andrew Gallatin
On 05/30/12 10:59, Colin Percival wrote: Hi all, The Xen virtual network interface has an issue (ok, really the issue is with the linux back-end, but that's what most people are using) where it can't handle scatter-gather writes with lots of pieces, aka. long mbuf chains. This currently bites us