Re: [PATCH] Use of unreferenced ifa in in6

2012-01-03 Thread Bjoern A. Zeeb
On 3. Jan 2012, at 22:22 , John Baldwin wrote: > On Tuesday, January 03, 2012 5:14:22 pm Hiroki Sato wrote: >> John Baldwin wrote >> in <201201031608.59688@freebsd.org>: >> >> jh> > With this patch in_lifaddr_ioctl() now looks more syntactically similar >> jh> > to in6_lifaddr_ioctl(). The

Re: [PATCH] Use of unreferenced ifa in in6

2012-01-03 Thread John Baldwin
On Tuesday, January 03, 2012 5:14:22 pm Hiroki Sato wrote: > John Baldwin wrote > in <201201031608.59688@freebsd.org>: > > jh> > With this patch in_lifaddr_ioctl() now looks more syntactically similar > jh> > to in6_lifaddr_ioctl(). They could look even more similar by eliminating > jh> > a

Re: [PATCH] Use of unreferenced ifa in in6

2012-01-03 Thread Hiroki Sato
John Baldwin wrote in <201201031608.59688@freebsd.org>: jh> > With this patch in_lifaddr_ioctl() now looks more syntactically similar jh> > to in6_lifaddr_ioctl(). They could look even more similar by eliminating jh> > a lot of whitespace changes present here or there. jh> jh> Hmmm. Actual

Re: [PATCH] Use of unreferenced ifa in in6

2012-01-03 Thread John Baldwin
On Tuesday, January 03, 2012 3:44:50 pm Sergey Kandaurov wrote: > On 4 January 2012 00:17, John Baldwin wrote: > > On Tuesday, January 03, 2012 2:36:25 pm Sergey Kandaurov wrote: > >> On 24 December 2011 00:08, John Baldwin wrote: > >> > The code to handle the SIOCGLIFADDR and SIOCDLIFADDR ioctls

Re: [PATCH] Use of unreferenced ifa in in6

2012-01-03 Thread Sergey Kandaurov
On 4 January 2012 00:17, John Baldwin wrote: > On Tuesday, January 03, 2012 2:36:25 pm Sergey Kandaurov wrote: >> On 24 December 2011 00:08, John Baldwin wrote: >> > The code to handle the SIOCGLIFADDR and SIOCDLIFADDR ioctls in >> > in6_lifaddr_ioctl() does not grab a reference to an ifnet addre

Re: [PATCH] Use of unreferenced ifa in in6

2012-01-03 Thread John Baldwin
On Tuesday, January 03, 2012 2:36:25 pm Sergey Kandaurov wrote: > On 24 December 2011 00:08, John Baldwin wrote: > > The code to handle the SIOCGLIFADDR and SIOCDLIFADDR ioctls in > > in6_lifaddr_ioctl() does not grab a reference to an ifnet address structure > > that it uses after dropping the IF

Re: [PATCH] Use of unreferenced ifa in in6

2012-01-03 Thread Sergey Kandaurov
On 24 December 2011 00:08, John Baldwin wrote: > The code to handle the SIOCGLIFADDR and SIOCDLIFADDR ioctls in > in6_lifaddr_ioctl() does not grab a reference to an ifnet address structure > that it uses after dropping the IF_ADDR_LOCK().  Based on other code that uses > a similar pattern of find

Re: [PATCH] Use of unreferenced ifa in in6

2012-01-03 Thread John Baldwin
On Tuesday, January 03, 2012 12:35:30 pm Bjoern A. Zeeb wrote: > > On 23. Dec 2011, at 20:08 , John Baldwin wrote: > > > The code to handle the SIOCGLIFADDR and SIOCDLIFADDR ioctls in > > in6_lifaddr_ioctl() does not grab a reference to an ifnet address structure > > that it uses after dropping

Re: [PATCH] Use of unreferenced ifa in in6

2012-01-03 Thread Bjoern A. Zeeb
On 23. Dec 2011, at 20:08 , John Baldwin wrote: > The code to handle the SIOCGLIFADDR and SIOCDLIFADDR ioctls in > in6_lifaddr_ioctl() does not grab a reference to an ifnet address structure > that it uses after dropping the IF_ADDR_LOCK(). Based on other code that > uses > a similar pattern