Re: [Bug 193246] Bug in IPv6 multicast join(), uncovered by Jenkins

2014-09-04 Thread 神明達哉
At Thu, 04 Sep 2014 10:42:59 -0400, John Baldwin wrote: > > It looks like on Solaris, they support IPv4-mapped multicast addresses for > > IPV6, and things work when they create an IPv6 socket, and then put an > > IPv4-mapped multicast address in it. For Linux, they have specific > > code paths

Re: [Bug 193246] Bug in IPv6 multicast join(), uncovered by Jenkins

2014-09-04 Thread John Baldwin
On Wednesday, September 03, 2014 06:39:53 AM Craig Rodrigues wrote: > On Wed, Sep 3, 2014 at 5:19 AM, Andrey V. Elsukov wrote: > > On 03.09.2014 14:05, bugzilla-nore...@freebsd.org wrote: > > > > Hi, > > > > you said that this code works in linux. I looked in the linux kernel > > source, and I t

Re: [Bug 193246] Bug in IPv6 multicast join(), uncovered by Jenkins

2014-09-03 Thread Andrey V. Elsukov
On 03.09.2014 17:39, Craig Rodrigues wrote: > On Wed, Sep 3, 2014 at 5:19 AM, Andrey V. Elsukov wrote: >> On 03.09.2014 14:05, bugzilla-nore...@freebsd.org wrote: >> >> Hi, >> >> you said that this code works in linux. I looked in the linux kernel >> source, and I think it should return EINVAL too

Re: [Bug 193246] Bug in IPv6 multicast join(), uncovered by Jenkins

2014-09-03 Thread Craig Rodrigues
On Wed, Sep 3, 2014 at 5:19 AM, Andrey V. Elsukov wrote: > On 03.09.2014 14:05, bugzilla-nore...@freebsd.org wrote: > > Hi, > > you said that this code works in linux. I looked in the linux kernel > source, and I think it should return EINVAL too. > net/ipv6/mcast.c:ipv6_sock_mc_join: > > 154

Re: [Bug 193246] Bug in IPv6 multicast join(), uncovered by Jenkins

2014-09-03 Thread Andrey V. Elsukov
On 03.09.2014 14:05, bugzilla-nore...@freebsd.org wrote: > In FreeBSD, in src/sys/netinet6/in6_mcast.c inside in6p_join_group(), there > is this: > > if (!IN6_IS_ADDR_MULTICAST(&gsa->sin6.sin6_addr)) > return (EINVAL); > > Since IN6_IS_ADDR_MULTICAST() only checks if the