Re: Inconsistency between net/if.c and several ethernet drivers

2002-07-18 Thread Bill Baumann
I'm working on just such a driver. It has layers that communicate with assumptions about structure alignment. Moving struct arpcom to the beginning breaks this, and requires scattered changes throughout. :-( Even so I'd rather do it the right way. Unless, I hear someone else disagreeing, I'l

RE: Inconsistency between net/if.c and several ethernet drivers

2002-07-17 Thread Bill Baumann
when this bug showed up in the wx driver. > > Jim > > > -Original Message- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED]]On Behalf Of Bill Baumann > > Sent: Wednesday, July 17, 2002 1:58 PM > > To: Kelly Yancey > > Cc: [EMAIL PROTECTE

Re: Inconsistency between net/if.c and several ethernet drivers

2002-07-17 Thread Garrett Wollman
< said: > Why bother with a if_softc field when the interface and softc pointer are > supposed to be the same? Also, the very old Lance driver (lnc) has this > problem. It makes me wonder how true we are to TCP/IP Illustrated... if_softc was added to pacify those who either didn't understand t

RE: Inconsistency between net/if.c and several ethernet drivers

2002-07-17 Thread Jim McGrath
PROTECTED]]On Behalf Of Bill Baumann > Sent: Wednesday, July 17, 2002 1:58 PM > To: Kelly Yancey > Cc: [EMAIL PROTECTED] > Subject: Re: Inconsistency between net/if.c and several ethernet drivers > > > > Pointers to interface and arpcom are clearly equivalent as arpcom c

Re: Inconsistency between net/if.c and several ethernet drivers

2002-07-17 Thread Bill Baumann
Pointers to interface and arpcom are clearly equivalent as arpcom contains the interface structure. The one definition for the combined structure makes it very safe. However, there are many definitions of the softc structure. Requiring arpcom to be at the beginning of all softc structs require

Re: Inconsistency between net/if.c and several ethernet drivers

2002-07-16 Thread Kelly Yancey
On Tue, 16 Jul 2002, Bill Baumann wrote: > > In net/if.c in a couple of places, the ethernet address is needed. This > is stored in the arpcom structure. A couple lines of code in if.c require > struct arpcom be at the very begining of device softc structures. Nearly > all drivers observe this