Re: Question on sysctl tree handling

2016-04-11 Thread K. Macy
On Mon, Apr 11, 2016 at 3:01 PM, Jack Vogel wrote: > Why should init have to be rerun just because TSO or CSUM is turned off or > on, > its a flag that is checked in the TX routines? I actually haven't looked in to it yet. But it does annoy the heck out of me. Nonetheless, it is the current state

Re: Question on sysctl tree handling

2016-04-11 Thread Jack Vogel
Hmmm, after so many years of unloading and reloading drivers, it just seemed like such a convenience :) But, instability isn't fun either, I've looked at bxe a little, such a monstrous driver :) I'll give it some thought, and maybe discuss it with David. Thanks. Cheers, Jack On Mon, Apr 11,

Re: Question on sysctl tree handling

2016-04-11 Thread Matt Joras
Expanding on what mmacy said... I don't think the benefits of "easy reconfiguration" are worth the headaches you're going to potentially run into in production. bxe(4) used to do this, and it caused us a lot of problems (i.e. panics) at $DAY_JOB. For example, if a lagg was on top of bxe and then y

Re: Question on sysctl tree handling

2016-04-11 Thread Jack Vogel
Why should init have to be rerun just because TSO or CSUM is turned off or on, its a flag that is checked in the TX routines? I am controlling some cases in the ioctl routine so it does the necessary things, but does not rerun all of init. If its a long running system that means its unlikely be g

Re: Question on sysctl tree handling

2016-04-11 Thread K. Macy
You do understand that init needs to be run every time interface settings are changed (TSO / PROMISC / CSUM/ etc)? Reallocating queues and interrupts every time is fragile (long running systems can run low on contiguous memory) and, in the common case that you're not actually changing the number, g

Re: Question on sysctl tree handling

2016-04-08 Thread Jack Vogel
LOL, why does it seem that as soon as I ask the answer hits me in the nose :) I found the sysctl_ctx_free call, sorry for the noise Jack On Fri, Apr 8, 2016 at 2:51 PM, Jack Vogel wrote: > > I have a driver design where the queue/ring/irq layout is done in init > rather > than in attach,

Question on sysctl tree handling

2016-04-08 Thread Jack Vogel
I have a driver design where the queue/ring/irq layout is done in init rather than in attach, allowing easy reconfiguration. What I'm not sure about is how to handle the sysctl tree during a reinit, I don't see a procedure to free up things so I can restructure :( Am I missing something, any point