On Wed, 2003/01/15 at 02:20:12 +1100, Bruce Evans wrote:
> On Tue, 14 Jan 2003, Martin Blapp wrote:
>
> >
> > Hi Thomas,
> >
> > > s = splnet();
> > > + if (so->so_state & (SS_ISCONNECTED | SS_ISCONNECTING)) {
> > > + splx(s);
> > > + return (EINVAL);
> > > + }
> > > error = (*
On Tue, 14 Jan 2003, Martin Blapp wrote:
>
> Hi Thomas,
>
> > s = splnet();
> > + if (so->so_state & (SS_ISCONNECTED | SS_ISCONNECTING)) {
> > + splx(s);
> > + return (EINVAL);
> > + }
> > error = (*so->so_proto->pr_usrreqs->pru_listen)(so, td);
> > if (error) {
Thomas Moestl wrote:
> > > [EINVAL] Listen() has been already called on the socket.
> The manpage change does not reflect the change in the patch :)
> It should be:
>
> [EINVAL]The socket is connected.
Oh. That's very different. Never mind. 8-).
-- Terry
To Uns
On Tue, 2003/01/14 at 02:51:03 -0800, Terry Lambert wrote:
> Martin Blapp wrote:
> > Can you commit this ? The fix looks appropriate, but the manpage should
> > also be changed to reflect the change.
> >
> > ERRORS
> > Listen() will fail if:
> >
> > [EBADF]The argument s is
Martin Blapp wrote:
> Can you commit this ? The fix looks appropriate, but the manpage should
> also be changed to reflect the change.
>
> ERRORS
> Listen() will fail if:
>
> [EBADF]The argument s is not a valid descriptor.
> [ENOTSOCK] The argument s is not a s
Hi Thomas,
> s = splnet();
> + if (so->so_state & (SS_ISCONNECTED | SS_ISCONNECTING)) {
> + splx(s);
> + return (EINVAL);
> + }
> error = (*so->so_proto->pr_usrreqs->pru_listen)(so, td);
> if (error) {
> splx(s);
>
Can you commit th
Hi Thomas,
> The solution should be to reject the listen() with EINVAL (which seems
> to be that standard-mandated error for connected sockets); patch
> attached.
Cool, thank you for the proposed solution. I suspected something like this;
rpcgen does generate quite broken code sometimes, and nob
On Mon, 2003/01/13 at 17:47:11 +0100, Martin Blapp wrote:
> #10 0xc03df350 in trap (frame=
> {tf_fs = 24, tf_es = -65520, tf_ds = 16, tf_edi = 2, tf_esi = -1031597312,
> tf_ebp = -854635944, tf_isp = -854635988, tf_ebx = -1031595264, tf_edx = 4,
> tf_ecx = 0, tf_eax = 0, tf_trapno = 12, tf_er
