Re: New ICMP limits

2004-12-11 Thread Michal Mertl
Suleiman Souhlal napsal(a): Hi, On Wed, 2004-12-08 at 09:51, Michal Mertl wrote: What do you think? Wouldn't it be better to move all the calls to badport_bandlim() to inside icmp_error()? It makes sense, yes. Unfortunately it isn't possible in most cases - echo/tstamp call icmp_reflect instead o

Re: New ICMP limits

2004-12-10 Thread Suleiman Souhlal
Hi, On Wed, 2004-12-08 at 09:51, Michal Mertl wrote: > What do you think? Wouldn't it be better to move all the calls to badport_bandlim() to inside icmp_error()? Bye -- Suleiman Souhlal| [EMAIL PROTECTED] The FreeBSD Project | [EMAIL PROTECTED] ___

Re: New ICMP limits

2004-12-09 Thread Andre Oppermann
Bruce M Simpson wrote: > > On Wed, Dec 08, 2004 at 03:53:07PM +0100, Andre Oppermann wrote: > > I'll take care of this but I'm busy right now. Look into it later this > > week. > > Thanks for looking into this, this is one of the items which came up on > the TODO lists of three separate project

Re: New ICMP limits

2004-12-08 Thread James
On Wed, Dec 08, 2004 at 06:21:07PM -0800, Bruce M Simpson wrote: > On Wed, Dec 08, 2004 at 03:53:07PM +0100, Andre Oppermann wrote: > > I'll take care of this but I'm busy right now. Look into it later this > > week. > > Thanks for looking into this, this is one of the items which came up on > t

Re: New ICMP limits

2004-12-08 Thread Bruce M Simpson
On Wed, Dec 08, 2004 at 03:53:07PM +0100, Andre Oppermann wrote: > I'll take care of this but I'm busy right now. Look into it later this week. Thanks for looking into this, this is one of the items which came up on the TODO lists of three separate projects (TowardEX's, XORP's, and the Network Ju

Re: New ICMP limits

2004-12-08 Thread Andre Oppermann
Michal Mertl wrote: > > Hello, > > I think some network administrators may want to set different maximum rate > for different types of ICMP replies. Currently the limit > net.inet.icmp.icmplim is enforced independently for the following cases - > ICMP echo-reply, ICMP timestamp reply, ICMP port u

New ICMP limits

2004-12-08 Thread Michal Mertl
Hello, I think some network administrators may want to set different maximum rate for different types of ICMP replies. Currently the limit net.inet.icmp.icmplim is enforced independently for the following cases - ICMP echo-reply, ICMP timestamp reply, ICMP port unreachable (generated as a respo