Re: NDP Ethernet address display

2011-01-07 Thread Boris Kochergin
On 01/07/11 21:09, Doug Barton wrote: On 01/07/2011 18:01, Boris Kochergin wrote: - snprintf(hbuf, sizeof(hbuf), "%x:%x:%x:%x:%x:%x", There are numerous examples of this string in the tree. Some of them seem like they may be correct, but many of them are obviously printing out mac addresses

Re: NDP Ethernet address display

2011-01-07 Thread Doug Barton
On 01/07/2011 18:01, Boris Kochergin wrote: - snprintf(hbuf, sizeof(hbuf), "%x:%x:%x:%x:%x:%x", There are numerous examples of this string in the tree. Some of them seem like they may be correct, but many of them are obviously printing out mac addresses and should be converted, one way or an

Re: NDP Ethernet address display

2011-01-07 Thread Boris Kochergin
On 01/07/11 20:26, Sergey Kandaurov wrote: On 8 January 2011 03:26, Boris Kochergin wrote: Hi. I noticed that ndp(8) doesn't zero-pad Ethernet addresses, which is inconsistent with arp(8): # ndp -an ... 2001:470:897b::1 0:30:48:b1:1b:9c em0 permanent R # arp -an ... ?

Re: NDP Ethernet address display

2011-01-07 Thread Sergey Kandaurov
On 8 January 2011 03:26, Boris Kochergin wrote: > Hi. I noticed that ndp(8) doesn't zero-pad Ethernet addresses, which is > inconsistent with arp(8): > > # ndp -an > ... > 2001:470:897b::1                     0:30:48:b1:1b:9c     em0 permanent R > > # arp -an > ... > ? (128.238.9.201) at 00:30:48:

Re: NDP Ethernet address display

2011-01-07 Thread Chuck Swiger
On Jan 7, 2011, at 4:26 PM, Boris Kochergin wrote: > As everything else I can think of zero-pads them, this makes it a little > annoying to grep for addresses, etc. Is this intentional? It is the case in > 7.x through CURRENT and the fix is quite simple: +1. MAC addresses should be displayed as

NDP Ethernet address display

2011-01-07 Thread Boris Kochergin
Hi. I noticed that ndp(8) doesn't zero-pad Ethernet addresses, which is inconsistent with arp(8): # ndp -an ... 2001:470:897b::1 0:30:48:b1:1b:9c em0 permanent R # arp -an ... ? (128.238.9.201) at 00:30:48:b1:1b:9c on em0 permanent [ethernet] As everything else I can th