Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-13 Thread Bjoern A. Zeeb
On Sat, 13 Jun 2009, Michael Tuexen wrote: On Jun 13, 2009, at 10:01 AM, Pyun YongHyeon wrote: On Sat, Jun 13, 2009 at 09:15:06AM +0200, Michael Tuexen wrote: On Jun 13, 2009, at 2:48 AM, Andrew Gallatin wrote: Michael Tuexen wrote: I'm not sure if we need additional IFCAP_RXCSUM6 IFCAP_T

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-13 Thread Michael Tuexen
On Jun 13, 2009, at 10:01 AM, Pyun YongHyeon wrote: On Sat, Jun 13, 2009 at 09:15:06AM +0200, Michael Tuexen wrote: On Jun 13, 2009, at 2:48 AM, Andrew Gallatin wrote: Michael Tuexen wrote: I'm not sure if we need additional IFCAP_RXCSUM6 IFCAP_TXCSUM6 capabilities... Why would we want to e

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-13 Thread Jack Vogel
I agree with Michael, I don't want to see this proliferation of capabilities, if you want checksum offload you get it whatever the IP type. Jack On Sat, Jun 13, 2009 at 1:01 AM, Pyun YongHyeon wrote: > On Sat, Jun 13, 2009 at 09:15:06AM +0200, Michael Tuexen wrote: > > On Jun 13, 2009, at 2:48

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-13 Thread Pyun YongHyeon
On Sat, Jun 13, 2009 at 09:15:06AM +0200, Michael Tuexen wrote: > On Jun 13, 2009, at 2:48 AM, Andrew Gallatin wrote: > > >Michael Tuexen wrote: > > > >> I'm not sure if we need additional IFCAP_RXCSUM6 IFCAP_TXCSUM6 > >> capabilities... Why would we want to enable IPv4 offloading and > >> not IPv

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-13 Thread Michael Tuexen
On Jun 13, 2009, at 2:48 AM, Andrew Gallatin wrote: Michael Tuexen wrote: > I'm not sure if we need additional IFCAP_RXCSUM6 IFCAP_TXCSUM6 > capabilities... Why would we want to enable IPv4 offloading and > not IPv6 or vice versa? I'd assume that some older hardware supports IPv4 offloads, but

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Kip Macy
> cxgb's silicon supports TSO+IPv6, so I'm not sure why things are the > way they are.  If the stack's tso6 works, then this is a bug in > cxgb. > It may not have supported it when the driver was ported - I know it didn't do v6 RSS. -Kip ___ freebsd-net

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Andrew Gallatin
Michael Tuexen wrote: > I'm not sure if we need additional IFCAP_RXCSUM6 IFCAP_TXCSUM6 > capabilities... Why would we want to enable IPv4 offloading and > not IPv6 or vice versa? I'd assume that some older hardware supports IPv4 offloads, but might not have support for IPv6 offloads. Drew _

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Michael Tuexen
On Jun 12, 2009, at 12:56 PM, Bjoern A. Zeeb wrote: On Fri, 12 Jun 2009, Pyun YongHyeon wrote: Hi, Yeah, there are no checksum offloading support for IPv6 under FreeBSD so there are no cases the frames are IPv6 when CSUM_IP/CSUM_TCP/CSUM_UDP/CSUM_TSO was set. The thing that scared me was s

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Bjoern A. Zeeb
On Fri, 12 Jun 2009, Navdeep Parhar wrote: Hi, cxgb(4) will not let you enable IFCAP_TSO6 on the interface. It has always been disallowed as far as I can tell. Yes, you have it in the logic bu you define it to 0;) #define IFCAP_TSO6 0x0 Not quite. TSO_SUPPORTED is defined and so c

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Bjoern A. Zeeb
On Fri, 12 Jun 2009, Andrew Gallatin wrote: Bjoern A. Zeeb wrote: On Fri, 12 Jun 2009, Navdeep Parhar wrote: On Fri, Jun 12, 2009 at 10:56:31AM +, Bjoern A. Zeeb wrote: On Fri, 12 Jun 2009, Pyun YongHyeon wrote: Hi, Yeah, there are no checksum offloading support for IPv6 under FreeBSD

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Navdeep Parhar
On Fri, Jun 12, 2009 at 05:38:46PM +, Bjoern A. Zeeb wrote: > On Fri, 12 Jun 2009, Navdeep Parhar wrote: > > >On Fri, Jun 12, 2009 at 10:56:31AM +, Bjoern A. Zeeb wrote: > >>On Fri, 12 Jun 2009, Pyun YongHyeon wrote: > >> > >>Hi, > >> > >>>Yeah, there are no checksum offloading support for

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Andrew Gallatin
Bjoern A. Zeeb wrote: >>> if there is no INET there should be no LRO for now, the capabilities >>> not advertised, etc. Be prepared in case LRO will arrive for IPv6. >> >> As to LRO & IPV6... I was going to port our LRO for IPv6, >> but discovered the state of IPv6 in FreeBSD is so disgraceful >

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Andrew Gallatin
Bjoern A. Zeeb wrote: On Fri, 12 Jun 2009, Navdeep Parhar wrote: On Fri, Jun 12, 2009 at 10:56:31AM +, Bjoern A. Zeeb wrote: On Fri, 12 Jun 2009, Pyun YongHyeon wrote: Hi, Yeah, there are no checksum offloading support for IPv6 under FreeBSD so there are no cases the frames are IPv6 whe

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Bjoern A. Zeeb
On Fri, 12 Jun 2009, Andrew Gallatin wrote: Hi, Bjoern A. Zeeb wrote: if_mxge: mxge_rx_csum() has one in_pseudo(). The function and callers already seem to know how do deal with results in case the csum can't be validated. So this should be a simple #i

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Bjoern A. Zeeb
On Fri, 12 Jun 2009, Andrew Gallatin wrote: Bjoern A. Zeeb wrote: As a sort of side-note, what about feature parity for INET6 for existing IPV4 features like TSO? Who is working on that? Ok, maybe we should write down the big list now. What all can we have? What do we already have? What do

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Bjoern A. Zeeb
On Fri, 12 Jun 2009, Navdeep Parhar wrote: On Fri, Jun 12, 2009 at 10:56:31AM +, Bjoern A. Zeeb wrote: On Fri, 12 Jun 2009, Pyun YongHyeon wrote: Hi, Yeah, there are no checksum offloading support for IPv6 under FreeBSD so there are no cases the frames are IPv6 when CSUM_IP/CSUM_TCP/CSUM

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Navdeep Parhar
On Fri, Jun 12, 2009 at 10:56:31AM +, Bjoern A. Zeeb wrote: > On Fri, 12 Jun 2009, Pyun YongHyeon wrote: > > Hi, > > >Yeah, there are no checksum offloading support for IPv6 under > >FreeBSD so there are no cases the frames are IPv6 when > >CSUM_IP/CSUM_TCP/CSUM_UDP/CSUM_TSO was set. > > The

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Andrew Gallatin
(apologies if this is the second copy you get, I've been having email issues) Bjoern A. Zeeb wrote: >> As a sort of side-note, what about feature parity for INET6 for >> existing IPV4 features like TSO? Who is working on that? > > Ok, maybe we should write down the big list now. What all can we

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Andrew Gallatin
Bjoern A. Zeeb wrote: if_mxge: mxge_rx_csum() has one in_pseudo(). The function and callers already seem to know how do deal with results in case the csum can't be validated. So this should be a simple #ifdef INET wrapping here; side note: the tcpudp_csum

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Andrew Gallatin
Bjoern A. Zeeb wrote: As a sort of side-note, what about feature parity for INET6 for existing IPV4 features like TSO? Who is working on that? Ok, maybe we should write down the big list now. What all can we have? What do we already have? What do we need? What needs to be changed? IPv4 CSUM

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-12 Thread Bjoern A. Zeeb
On Fri, 12 Jun 2009, Pyun YongHyeon wrote: Hi, Yeah, there are no checksum offloading support for IPv6 under FreeBSD so there are no cases the frames are IPv6 when CSUM_IP/CSUM_TCP/CSUM_UDP/CSUM_TSO was set. The thing that scared me was sys/netinet/tcp_subr.c:tcp_maxmtu6(). What I had missed

Re: Ethernet NIC drivers depending unconditionally on INET

2009-06-11 Thread Pyun YongHyeon
On Thu, Jun 11, 2009 at 08:33:28PM +, Bjoern A. Zeeb wrote: > Hi, > > as announced in my other mail to current@ and net@ I added the > mandatory "INET" dependency to 12 Ethernet NIC drivers. Additionally > I am adding if_bridge here as well. > > Those drivers should be fixed and once done t

Ethernet NIC drivers depending unconditionally on INET

2009-06-11 Thread Bjoern A. Zeeb
Hi, as announced in my other mail to current@ and net@ I added the mandatory "INET" dependency to 12 Ethernet NIC drivers. Additionally I am adding if_bridge here as well. Those drivers should be fixed and once done the (mandatory) inet dependency should be removed again from sys/conf/files fo