[Bug 197139] Double cleanup in igb_attach

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197139 Eric Joyner changed: What|Removed |Added Status|New |In Progress Assignee|freeb

[Bug 197139] Double cleanup in igb_attach

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197139 Sean Bruno changed: What|Removed |Added CC||e...@freebsd.org, |

[Bug 197139] Double cleanup in igb_attach

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197139 Mark Linimon changed: What|Removed |Added Keywords||patch Assignee|freebsd-b.

Re: Double cleanup in igb_attach

c: hiren panchasara mailto:hi...@strugglingcoder.info>>, "freebsd-net@freebsd.org<mailto:freebsd-net@freebsd.org>" mailto:freebsd-net@freebsd.org>>, "j...@freebsd.org<mailto:j...@freebsd.org>" mailto:j...@freebsd.org>> Subject: Re: Double cleanup in igb

Re: Double cleanup in igb_attach

esday, January 27, 2015 at 12:42 PM > To: Sreekanth Rupavatharam > Cc: hiren panchasara , " > freebsd-net@freebsd.org" , "j...@freebsd.org" < > j...@freebsd.org> > Subject: Re: Double cleanup in igb_attach > > Yes, I will look them over. > > Jack >

Re: Double cleanup in igb_attach

tharam mailto:rupav...@juniper.net>> Cc: hiren panchasara mailto:hi...@strugglingcoder.info>>, "freebsd-net@freebsd.org<mailto:freebsd-net@freebsd.org>" mailto:freebsd-net@freebsd.org>>, "j...@freebsd.org<mailto:j...@freebsd.org>" mailto:j...@freebsd

Re: Double cleanup in igb_attach

Done, I have also attached the patch in the bug report. -- Thanks, Sreekanth On 1/27/15, 12:54 PM, "Adrian Chadd" wrote: >Hi! > >Sreekanth - this does look like it is valid and needs fixing. Just >file a FreeBSD PR (bugs.freebsd.org/submit/) and we'll assign it to >the intel team

Re: Double cleanup in igb_attach

Hi! Sreekanth - this does look like it is valid and needs fixing. Just file a FreeBSD PR (bugs.freebsd.org/submit/) and we'll assign it to the intel team. Thanks! -a On 27 January 2015 at 12:42, Jack Vogel wrote: > Yes, I will look them over. > > Jack > > > On Tue, Jan 27, 2015 at 12:38 PM,

Re: Double cleanup in igb_attach

Yes, I will look them over. Jack On Tue, Jan 27, 2015 at 12:38 PM, Sreekanth Rupavatharam < rupav...@juniper.net> wrote: > Thanks jack, > Now, can you please review these changes? And commit if you deem it > fit? > > Thanks, > > -Sreekanth > > On Jan 27, 2015, at 12:24 PM, "Jack Vogel"

Re: Double cleanup in igb_attach

Thanks jack, Now, can you please review these changes? And commit if you deem it fit? Thanks, -Sreekanth On Jan 27, 2015, at 12:24 PM, "Jack Vogel" mailto:jfvo...@gmail.com>> wrote: E, I am one of those people :) (jack.vo...@intel.com) Jack On Tue, Ja

Re: Double cleanup in igb_attach

E, I am one of those people :) (jack.vo...@intel.com) Jack On Tue, Jan 27, 2015 at 12:21 PM, Sreekanth Rupavatharam < rupav...@juniper.net> wrote: > Definitely, but I didn't have the contact info of those people. > > Thanks, > > -Sreekanth > > On Jan 27, 2015, at 12:15 PM, "Jack Vogel"

Re: Double cleanup in igb_attach

Definitely, but I didn't have the contact info of those people. Thanks, -Sreekanth On Jan 27, 2015, at 12:15 PM, "Jack Vogel" mailto:jfvo...@gmail.com>> wrote: If you want something committed to an Intel driver, asking Intel might be the courteous thing to do, don't you think? Jack On Tue,

Re: Double cleanup in igb_attach

If you want something committed to an Intel driver, asking Intel might be the courteous thing to do, don't you think? Jack On Tue, Jan 27, 2015 at 11:51 AM, Sreekanth Rupavatharam < rupav...@juniper.net> wrote: > Hiren, > Can you help commit this? > > Index: if_igb.c > > ==

Re: Double cleanup in igb_attach

Hiren, Can you help commit this? Index: if_igb.c === --- if_igb.c (revision 298053) +++ if_igb.c (working copy) @@ -723,7 +723,8 @@ igb_attach(device_t dev) return (0); err_late: - igb_detach(dev); + if(igb_detach(dev) ==

Re: Double cleanup in igb_attach

On Tue, Jan 27, 2015 at 07:36:17PM +, Sreekanth Rupavatharam wrote: > > > >Seems reasonable to me at the first glance. > > > >We need to call IGB_CORE_LOCK_DESTROY(adapter) before returning though. > > > Not necessary. igb_detach does that. Bah, I read that call inside detach as UNLOCK. Yeah,

Re: Double cleanup in igb_attach

+ Jack On Tue, Jan 27, 2015 at 12:00:19AM +, Sreekanth Rupavatharam wrote: > Apologies if this is not the right forum. In igb_attach function, we have > this code. > err_late: > igb_detach(dev); > igb_free_transmit_structures(adapter); > igb_free_receive_structures(adapter); >

Re: Double cleanup in igb_attach

> >Seems reasonable to me at the first glance. > >We need to call IGB_CORE_LOCK_DESTROY(adapter) before returning though. > Not necessary. igb_detach does that. ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-n

Double cleanup in igb_attach

Apologies if this is not the right forum. In igb_attach function, we have this code. err_late: igb_detach(dev); igb_free_transmit_structures(adapter); igb_free_receive_structures(adapter); igb_release_hw_control(adapter); err_pci: igb_free_pci_resources(adapter);