Re: Calling m_pullup in ether_input

2004-10-09 Thread Luigi Rizzo
On Sat, Oct 09, 2004 at 12:34:34AM +0400, Gleb Smirnoff wrote: > On Fri, Oct 08, 2004 at 06:15:15PM +0300, Giorgos Keramidas wrote: > G> In ether_input() we unconditionaly discard the mbufs whose m_len is less than > G> ETHER_HDR_LEN. A bit higher M_PKTHDR has been checked but the check made > G>

Re: Calling m_pullup in ether_input

2004-10-08 Thread Julian Elischer
Giorgos Keramidas wrote: On 2004-10-09 00:34, Gleb Smirnoff <[EMAIL PROTECTED]> wrote: On Fri, Oct 08, 2004 at 06:15:15PM +0300, Giorgos Keramidas wrote: G> In ether_input() we unconditionaly discard the mbufs whose m_len is less than G> ETHER_HDR_LEN. A bit higher M_PKTHDR has been checked bu

Re: Calling m_pullup in ether_input

2004-10-08 Thread Giorgos Keramidas
On 2004-10-09 00:58, Gleb Smirnoff <[EMAIL PROTECTED]> wrote: > On Fri, Oct 08, 2004 at 11:51:17PM +0300, Giorgos Keramidas wrote: > G> Not really. Just trying to see if there _was_ any packet loss first. > G> After running for several hours, the counters are still zero. I think > G> this means t

Re: Calling m_pullup in ether_input

2004-10-08 Thread Gleb Smirnoff
On Fri, Oct 08, 2004 at 11:51:17PM +0300, Giorgos Keramidas wrote: G> Not really. Just trying to see if there _was_ any packet loss first. G> After running for several hours, the counters are still zero. I think G> this means the case of dropped packets would be so rare that there's no G> real re

Re: Calling m_pullup in ether_input

2004-10-08 Thread Giorgos Keramidas
On 2004-10-09 00:34, Gleb Smirnoff <[EMAIL PROTECTED]> wrote: > On Fri, Oct 08, 2004 at 06:15:15PM +0300, Giorgos Keramidas wrote: > G> In ether_input() we unconditionaly discard the mbufs whose m_len is less than > G> ETHER_HDR_LEN. A bit higher M_PKTHDR has been checked but the check made > G> b

Re: Calling m_pullup in ether_input

2004-10-08 Thread Gleb Smirnoff
On Fri, Oct 08, 2004 at 06:15:15PM +0300, Giorgos Keramidas wrote: G> In ether_input() we unconditionaly discard the mbufs whose m_len is less than G> ETHER_HDR_LEN. A bit higher M_PKTHDR has been checked but the check made G> before discarding the frame doesn't pay attention to the m->m_pkthdr.le

Calling m_pullup in ether_input

2004-10-08 Thread Giorgos Keramidas
In ether_input() we unconditionaly discard the mbufs whose m_len is less than ETHER_HDR_LEN. A bit higher M_PKTHDR has been checked but the check made before discarding the frame doesn't pay attention to the m->m_pkthdr.len (the total packet length). I am trying to find out how often this happens