Re: Bug in net/route.c function rtredirect()

2002-06-04 Thread Ruslan Ermilov
On Tue, Jun 04, 2002 at 10:24:49AM +0200, Andre Oppermann wrote: > Ruslan Ermilov wrote: > > > > On Tue, Jun 04, 2002 at 12:05:51AM +0200, Andre Oppermann wrote: > > > After reading this whole redirect stuff a couple of time I've come to > > > the conclusion that the function is right as it is th

Re: Bug in net/route.c function rtredirect()

2002-06-04 Thread Andre Oppermann
Ruslan Ermilov wrote: > > On Tue, Jun 04, 2002 at 12:05:51AM +0200, Andre Oppermann wrote: > > After reading this whole redirect stuff a couple of time I've come to > > the conclusion that the function is right as it is there. There is no > > such bug as I described it. The rtalloc1() in rtredire

Re: Bug in net/route.c function rtredirect()

2002-06-03 Thread Ruslan Ermilov
On Tue, Jun 04, 2002 at 12:05:51AM +0200, Andre Oppermann wrote: > Ruslan Ermilov wrote: > > > > On Sat, Jun 01, 2002 at 12:49:51PM +0200, Andre Oppermann wrote: > > > You're right but the refcount decrementation will be done, just in a > > > different place. In the "done:" section the rtfree() w

Re: Bug in net/route.c function rtredirect()

2002-06-03 Thread Garrett Wollman
< said: > A bug is that host routes created by redirect are never being purged. > But that one has been present for a long (?) time. You are expected to be running a routing process (like `routed' in router-discovery mode) which will delete them for you. I agree that this is not a reasonable ex

Re: Bug in net/route.c function rtredirect()

2002-06-03 Thread Andre Oppermann
Ruslan Ermilov wrote: > > On Sat, Jun 01, 2002 at 12:49:51PM +0200, Andre Oppermann wrote: > > You're right but the refcount decrementation will be done, just in a > > different place. In the "done:" section the rtfree() will be done also > > in the case when an existing host route was already pr

Re: Bug in net/route.c function rtredirect()

2002-06-02 Thread Ruslan Ermilov
On Sat, Jun 01, 2002 at 12:49:51PM +0200, Andre Oppermann wrote: > Ruslan Ermilov wrote: > > > > On Sat, Jun 01, 2002 at 02:56:37AM +0200, Andre Oppermann wrote: > > > Hi all, > > > > > > I've found another bug in net/route.c in the function rtredirect(). > > > > > > When learning a new gateway f

Re: Bug in net/route.c function rtredirect()

2002-06-01 Thread Andre Oppermann
Ruslan Ermilov wrote: > > On Sat, Jun 01, 2002 at 02:56:37AM +0200, Andre Oppermann wrote: > > Hi all, > > > > I've found another bug in net/route.c in the function rtredirect(). > > > > When learning a new gateway from a ICMP redirect icmp_input calls > > rtredirect() in net/route.c. rtredirect

Re: Bug in net/route.c function rtredirect()

2002-06-01 Thread Ruslan Ermilov
On Sat, Jun 01, 2002 at 02:56:37AM +0200, Andre Oppermann wrote: > Hi all, > > I've found another bug in net/route.c in the function rtredirect(). > > When learning a new gateway from a ICMP redirect icmp_input calls > rtredirect() in net/route.c. rtredirect is doing some sanity checks > and the

Bug in net/route.c function rtredirect()

2002-05-31 Thread Andre Oppermann
Hi all, I've found another bug in net/route.c in the function rtredirect(). When learning a new gateway from a ICMP redirect icmp_input calls rtredirect() in net/route.c. rtredirect is doing some sanity checks and then creates, if it did not find an existing host route, a new host route tagged w