Re: Bug in net/route.[ch] with rmx_pksent while cloning

2002-05-31 Thread Mike Silbersack
On Fri, 31 May 2002, Andre Oppermann wrote: > I think it will break. Isn't there a compiler warning in net/rtsocket.c > on 64bit platforms about the u_long to int assignment? > > IMO the right solution would to simply axe this field from rt_msghdr. > It serves no purpose. At least none of the ba

Re: Bug in net/route.[ch] with rmx_pksent while cloning

2002-05-31 Thread Andre Oppermann
Mike Silbersack wrote: > > On Fri, 31 May 2002, Andre Oppermann wrote: > > Ok, here we go. > > > if (req == RTM_RESOLVE) { > > rt->rt_rmx = (*ret_nrt)->rt_rmx; /* copy metrics */ > > + rt->rt_rmx.rmx_pksent = 0; /* reset packet counter */

Re: Bug in net/route.[ch] with rmx_pksent while cloning

2002-05-30 Thread Mike Silbersack
On Fri, 31 May 2002, Andre Oppermann wrote: Ok, here we go. > if (req == RTM_RESOLVE) { > rt->rt_rmx = (*ret_nrt)->rt_rmx; /* copy metrics */ > + rt->rt_rmx.rmx_pksent = 0; /* reset packet counter */ This has been committed to -current, a

Re: Bug in net/route.[ch] with rmx_pksent while cloning

2002-05-30 Thread Mike Silbersack
On Fri, 31 May 2002, Andre Oppermann wrote: > Hi all, > > there is a bug in sys/route.[ch] with the rmx_pksent statistics (which > counts how many times the route has been used to forward a ip packet). > > Silby, Bosko or Luigi, could you have a look at this? > > -- > Andre Sure, I'll take a

Bug in net/route.[ch] with rmx_pksent while cloning

2002-05-30 Thread Andre Oppermann
Hi all, there is a bug in sys/route.[ch] with the rmx_pksent statistics (which counts how many times the route has been used to forward a ip packet). The bug is pretty simply: When cloning an rtentry in rtrequest1() the metrics get copied one to one. Unfortunatly also the rmx_pksent sta- tistic