Re: Addressing refcount issues in ip6_setdstifaddr and ip6_getdstifaddr routines.

2014-10-03 Thread Andrey V. Elsukov
On 03.10.2014 18:03, Vedant Mathur wrote: > Andrey, > > Not a bad option. I saw you deleted the ip6_findaux routine which is > used in route6_input. You have a ifdef around it. Whats that for? Hi, It isn't my ifdef, it was here and never has been used in FreeBSD. Probably similar functional wil

Re: Addressing refcount issues in ip6_setdstifaddr and ip6_getdstifaddr routines.

2014-10-03 Thread Vedant Mathur
Andrey, Not a bad option. I saw you deleted the ip6_findaux routine which is used in route6_input. You have a ifdef around it. Whats that for? -Vedant On Wed, Oct 1, 2014 at 12:05 AM, Andrey V. Elsukov wrote: > On 30.09.2014 19:24, Vedant Mathur wrote: > > *Solution 2:* > > > > In ip6_setdsti

Re: Addressing refcount issues in ip6_setdstifaddr and ip6_getdstifaddr routines.

2014-09-30 Thread Andrey V. Elsukov
On 30.09.2014 19:24, Vedant Mathur wrote: > *Solution 2:* > > In ip6_setdstifaddr() routine we can access the struct ifa using > ia6->ia_ifa and retrieve the IP address from the ifa and then push it > into the m_tag instead of the struct in6_ifaddr pointer. Then we will > not require a refcnt incr

Addressing refcount issues in ip6_setdstifaddr and ip6_getdstifaddr routines.

2014-09-30 Thread Vedant Mathur
Hi all, I am trying to address the refcount issues in the routine ip6_setdstifaddr defined in the file ip6_input.c. The issue is described below: The ip6_setdstifaddr routine is responsible for adding m_tags to an mbuf and stashing the struct in6_ifaddr reference in the m_tag. Since the in6_ifa