Re: [ping6] freeaddrinfo()

2010-03-15 Thread Earl Lapus
On Tue, Mar 16, 2010 at 12:06 AM, Hajimu UMEMOTO wrote: > > Yup, it should be good practice.  But, this is rather intentional. > The `hostname' variable points to res->ai_canonname, and is used > later.  This is why the `res' variable is declared globally. > > Sincerely, > I see. I was unable to

Re: [ping6] freeaddrinfo()

2010-03-15 Thread Hajimu UMEMOTO
Hi, > On Sat, 13 Mar 2010 20:25:29 +0800 > Earl Lapus said: earl> I was browsing through the ping6 code and I noticed that one earl> particular call to getaddrinfo() didn't have a freeaddrinfo() pair. earl> All calls to getaddrinfo() should have an equivalent freeaddrinfo(), right? Yup

Re: [ping6] freeaddrinfo()

2010-03-14 Thread Earl Lapus
On Sun, Mar 14, 2010 at 1:24 PM, Doug Barton wrote: > > For all such issues, please file a PR first so it doesn't get lost. When > you get the PR confirmation back, feel free to alert the list to its > existence. > As advised, I've just filed a PR - (PR number: 144730) -- There are seven words

Re: [ping6] freeaddrinfo()

2010-03-13 Thread Doug Barton
On 03/13/10 04:25, Earl Lapus wrote: > Hi, > > I was browsing through the ping6 code and I noticed that one > particular call to getaddrinfo() didn't have a freeaddrinfo() pair. > All calls to getaddrinfo() should have an equivalent freeaddrinfo(), right? > > Attached is a patch that "tries-to-re

[ping6] freeaddrinfo()

2010-03-13 Thread Earl Lapus
Hi, I was browsing through the ping6 code and I noticed that one particular call to getaddrinfo() didn't have a freeaddrinfo() pair. All calls to getaddrinfo() should have an equivalent freeaddrinfo(), right? Attached is a patch that "tries-to-resolve" this very small issue (applies cleanly on an