Re: [REVIEW/TEST] polling(4) changes

2005-10-01 Thread Bruce Evans
On Fri, 30 Sep 2005, Gleb Smirnoff wrote: The attached patch removes: ... - poll in trap feature. Sorry, we can't acquire mutexes in trap(). Anyone used it, anyway? This is the most broken part of DEVICE_POLLING (which I consider to be mostly broken). Hopefully no one used it. Poll in tr

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Gleb Smirnoff
On Fri, Sep 30, 2005 at 08:29:43PM +0200, Andre Oppermann wrote: A> > It adds a stub function call every tick. The function returns almost A> > immediately if no interfaces do polling. A> A> If it does a FOREACH(interface) then it should stay as a kernel option. It isn't. Just 'if (poll_handlers

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Luigi Rizzo
On Fri, Sep 30, 2005 at 08:29:43PM +0200, Andre Oppermann wrote: ... > > It adds a stub function call every tick. The function returns almost > > immediately if no interfaces do polling. > > If it does a FOREACH(interface) then it should stay as a kernel option. this wasn't the case when i first

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Andre Oppermann
Gleb Smirnoff wrote: > > On Fri, Sep 30, 2005 at 08:13:22PM +0200, Pawel Jakub Dawidek wrote: > P> On Fri, Sep 30, 2005 at 08:03:02PM +0400, Gleb Smirnoff wrote: > P> +> On Fri, Sep 30, 2005 at 04:40:00PM +0400, Gleb Smirnoff wrote: > P> +> T> [please, follow-up on net@ only] > P> +> T> > P> +>

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Gleb Smirnoff
On Fri, Sep 30, 2005 at 08:13:22PM +0200, Pawel Jakub Dawidek wrote: P> On Fri, Sep 30, 2005 at 08:03:02PM +0400, Gleb Smirnoff wrote: P> +> On Fri, Sep 30, 2005 at 04:40:00PM +0400, Gleb Smirnoff wrote: P> +> T> [please, follow-up on net@ only] P> +> T> P> +> T> Colleagues, P> +> T> P> +> T>

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Pawel Jakub Dawidek
On Fri, Sep 30, 2005 at 08:03:02PM +0400, Gleb Smirnoff wrote: +> On Fri, Sep 30, 2005 at 04:40:00PM +0400, Gleb Smirnoff wrote: +> T> [please, follow-up on net@ only] +> T> +> T> Colleagues, +> T> +> T> here are some patches for review. +> +> I have some changes to patch after last compil

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Gleb Smirnoff
On Fri, Sep 30, 2005 at 04:40:00PM +0400, Gleb Smirnoff wrote: T> [please, follow-up on net@ only] T> T> Colleagues, T> T> here are some patches for review. I have some changes to patch after last compile, and haven't tested them befire sending patch. Here is an updated one. -- Totus tu

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread John Baldwin
On Friday 30 September 2005 08:40 am, Gleb Smirnoff wrote: > [please, follow-up on net@ only] > > Colleagues, > > here are some patches for review. > > Problems addressed: > > 1) When Giant was removed from polling a problem was introduced. The idle > poll feature was broken. The idle pol

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Robert Watson writes: >On Fri, 30 Sep 2005, Poul-Henning Kamp wrote: > >> I still think we should stop having this network-centric view of polling >> and implement _real_ *device* polling, so that other device types can >> use it as well. > >While I agree that we s

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Robert Watson
On Fri, 30 Sep 2005, Poul-Henning Kamp wrote: I still think we should stop having this network-centric view of polling and implement _real_ *device* polling, so that other device types can use it as well. While I agree that we should offer polling to non-network device drivers also, I think

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Gleb Smirnoff
On Fri, Sep 30, 2005 at 02:43:51PM +0200, Poul-Henning Kamp wrote: P> I still think we should stop having this network-centric view of P> polling and implement _real_ *device* polling, so that other P> device types can use it as well. I agree with both hands. My current work is aimed at RELENG_6 o

Re: [REVIEW/TEST] polling(4) changes

2005-09-30 Thread Poul-Henning Kamp
I still think we should stop having this network-centric view of polling and implement _real_ *device* polling, so that other device types can use it as well. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD si

[REVIEW/TEST] polling(4) changes

2005-09-30 Thread Gleb Smirnoff
[please, follow-up on net@ only] Colleagues, here are some patches for review. Problems addressed: 1) When Giant was removed from polling a problem was introduced. The idle poll feature was broken. The idle poll thread can enter polling handler on one interface and put to sleep for a