Re: [PATH] ALTQ(9) codel algorithm implementation

2013-06-17 Thread Gleb Smirnoff
Ermal, On Fri, Jun 14, 2013 at 03:05:16PM +0200, Ermal Lu?i wrote: E> >> I'm afraid we can't grow mbuf packet header with 8 bytes just to satisfy E> >> the ALTQ codel algo, which would definitely have a limited usage among E> >> FreeBSD users. Thus, "enqueue_time" should go into mbuf_tags(9) not

Re: [PATH] ALTQ(9) codel algorithm implementation

2013-06-14 Thread Julian Elischer
On 6/14/13 6:08 PM, Luigi Rizzo wrote: On Fri, Jun 14, 2013 at 01:51:25PM +0400, Gleb Smirnoff wrote: Ermal, ... I'm afraid we can't grow mbuf packet header with 8 bytes just to satisfy the ALTQ codel algo, which would definitely have a limited usage among FreeBSD users. Thus, "enqueue_time

Re: [PATH] ALTQ(9) codel algorithm implementation

2013-06-14 Thread Ermal Luçi
On Fri, Jun 14, 2013 at 12:34 PM, Andre Oppermann wrote: > On 14.06.2013 11:51, Gleb Smirnoff wrote: > >>Ermal, >> >> On Mon, Jun 10, 2013 at 03:43:12PM +0200, Ermal Lu?i wrote: >> E> at location [1] can be found a patch for Codel[3] algorithm >> implementation. >> E> >> E> Triggered by a mai

Re: [PATH] ALTQ(9) codel algorithm implementation

2013-06-14 Thread Gleb Smirnoff
On Fri, Jun 14, 2013 at 01:51:25PM +0400, Gleb Smirnoff wrote: T> Assuming all above is taken into account, IMHO, the patch is okay to be included T> into FreeBSD. Thanks! P.S. Patch also lacks update to manual pages altq.9 and pf.conf.5. These should be written and committed in one commit with t

Re: [PATH] ALTQ(9) codel algorithm implementation

2013-06-14 Thread Andre Oppermann
On 14.06.2013 11:51, Gleb Smirnoff wrote: Ermal, On Mon, Jun 10, 2013 at 03:43:12PM +0200, Ermal Lu?i wrote: E> at location [1] can be found a patch for Codel[3] algorithm implementation. E> E> Triggered by a mail to the mailing lists[2] of OpenBSD i completed the E> implementation for FreeBS

Re: [PATH] ALTQ(9) codel algorithm implementation

2013-06-14 Thread Gleb Smirnoff
Luigi, On Fri, Jun 14, 2013 at 12:08:28PM +0200, Luigi Rizzo wrote: L> > I'm afraid we can't grow mbuf packet header with 8 bytes just to satisfy L> > the ALTQ codel algo, which would definitely have a limited usage among L> > FreeBSD users. Thus, "enqueue_time" should go into mbuf_tags(9) not i

Re: [PATH] ALTQ(9) codel algorithm implementation

2013-06-14 Thread Luigi Rizzo
On Fri, Jun 14, 2013 at 01:51:25PM +0400, Gleb Smirnoff wrote: > Ermal, ... > I'm afraid we can't grow mbuf packet header with 8 bytes just to satisfy > the ALTQ codel algo, which would definitely have a limited usage among > FreeBSD users. Thus, "enqueue_time" should go into mbuf_tags(9) not int

Re: [PATH] ALTQ(9) codel algorithm implementation

2013-06-14 Thread Gleb Smirnoff
Ermal, On Mon, Jun 10, 2013 at 03:43:12PM +0200, Ermal Lu?i wrote: E> at location [1] can be found a patch for Codel[3] algorithm implementation. E> E> Triggered by a mail to the mailing lists[2] of OpenBSD i completed the E> implementation for FreeBSD. E> E> It allows to use codel as the sing

[PATH] ALTQ(9) codel algorithm implementation

2013-06-10 Thread Ermal Luçi
Hello, at location [1] can be found a patch for Codel[3] algorithm implementation. Triggered by a mail to the mailing lists[2] of OpenBSD i completed the implementation for FreeBSD. It allows to use codel as the single configured discipline on an interface. Also it can be used as a sub disciplin