Re: [PATCH] Interface description

2010-01-26 Thread John Baldwin
On Tuesday 26 January 2010 3:21:42 pm Xin LI wrote: > On 2010/01/26 08:40, John Baldwin wrote: > > I just have two suggestions/comments: > > @@ -295,6 +295,7 @@ struct ifreq { > [...] > > I prefer to not have this all on one line, but to instead be: > [...] > > Even better would be to actually

Re: [PATCH] Interface description

2010-01-26 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2010/01/26 08:40, John Baldwin wrote: > I just have two suggestions/comments: > @@ -295,6 +295,7 @@ struct ifreq { [...] > I prefer to not have this all on one line, but to instead be: [...] > Even better would be to actually define a separate

Re: [PATCH] Interface description

2010-01-26 Thread John Baldwin
On Monday 25 January 2010 5:10:35 pm Xin LI wrote: > Hi, > > I have revised the patchset based on feedback received. This version: > > - Unbreak the case when libpcap is being built for pre-ifdescr world. > - Documents the descr and -descr primitives for ifconfig(8), they are > intended for Op

Re: [PATCH] Interface description

2010-01-25 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2010/01/25 14:33, Antoine Brodin wrote: > On Mon, Jan 25, 2010 at 11:10 PM, Xin LI wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi, >> >> I have revised the patchset based on feedback received. This version: >> >> - Unbreak th

Re: [PATCH] Interface description

2010-01-25 Thread Antoine Brodin
On Mon, Jan 25, 2010 at 11:10 PM, Xin LI wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > I have revised the patchset based on feedback received.  This version: > >  - Unbreak the case when libpcap is being built for pre-ifdescr world. >  - Documents the descr and -descr primit

[PATCH] Interface description

2010-01-25 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I have revised the patchset based on feedback received. This version: - Unbreak the case when libpcap is being built for pre-ifdescr world. - Documents the descr and -descr primitives for ifconfig(8), they are intended for OpenBSD compatibilit