Re: [PATCH] Fix integer truncation in systat -ifstat

2014-09-12 Thread Olivier Cochard-Labbé
On Fri, Sep 12, 2014 at 8:41 AM, Bruce Evans wrote: > Only differences in the counters are used except in 1 place that is > broken in other ways, so overflow is only a large problem starting at > about 40 Gbps. At only 10 Gbps, 32-bit counters are enough with a > refresh interval of 1 second bu

Re: [PATCH] Fix integer truncation in systat -ifstat

2014-09-12 Thread Bruce Evans
On Thu, 11 Sep 2014, Ryan Stone wrote: systat -ifstat currently truncates byte counters down to 32-bit integers. The following fixes the issue, but I'm not very happy with it. u_long is what the rest of our code uses for network counters, but that ends up meaning that our counters are 32-bits

[PATCH] Fix integer truncation in systat -ifstat

2014-09-11 Thread Ryan Stone
systat -ifstat currently truncates byte counters down to 32-bit integers. The following fixes the issue, but I'm not very happy with it. u_long is what the rest of our code uses for network counters, but that ends up meaning that our counters are 32-bits wide on 32-bit platforms. I could make it