Re: [PATCH] Convert ixl(4) and ixlv(4) to ifcounters, and fix some counter bugs

2014-09-27 Thread Gleb Smirnoff
Thanks, Eric. Ryan, will you commit? The cxgbe(4) is already updated by Navdeep. Me and melifaro@ are finishing lagg(4). Once Intel drivers are done, we can go forward for counter(9) in struct ifnet. On Fri, Sep 26, 2014 at 03:25:59PM -0700, Eric Joyner wrote: E> I approve of this patch --

Re: [PATCH] Convert ixl(4) and ixlv(4) to ifcounters, and fix some counter bugs

2014-09-26 Thread Eric Joyner
I approve of this patch -- I tested it on ixl and ixlv on stable/10, and at least the sysctl stats still look good. --- - Eric Joyner On Thu, Sep 25, 2014 at 5:08 AM, Gleb Smirnoff wrote: > On Tue, Sep 23, 2014 at 07:18:51PM -0400, Ryan Stone wrote: > R> The patch below converts the ixl(4) and

Re: [PATCH] Convert ixl(4) and ixlv(4) to ifcounters, and fix some counter bugs

2014-09-25 Thread Gleb Smirnoff
On Tue, Sep 23, 2014 at 07:18:51PM -0400, Ryan Stone wrote: R> The patch below converts the ixl(4) and ixlv(4) drivers to use the new R> ifcounter interface. I've hidden the interface behind some macros to R> ensure that the driver continues to compile for FreeBSD 10 and R> earlier. The result of

[PATCH] Convert ixl(4) and ixlv(4) to ifcounters, and fix some counter bugs

2014-09-23 Thread Ryan Stone
The patch below converts the ixl(4) and ixlv(4) drivers to use the new ifcounter interface. I've hidden the interface behind some macros to ensure that the driver continues to compile for FreeBSD 10 and earlier. The result of the macros is that the ifcounter implementation is somewhat clunkier th