This revision was automatically updated to reflect the committed changes.
Closed by commit rS311475: if: Defer the if_up until the ifnet.if_ioctl is
called. (authored by sephe).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D8905?vs=23258&id=23645#toc
REPOSITORY
rS FreeBSD src reposito
gnn accepted this revision.
This revision has a positive review.
REVISION DETAIL
https://reviews.freebsd.org/D8905
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com,
honzhan_microsoft.com, howard0su_g
karels added a comment.
Seems fine to me; will let someone else approve.
REVISION DETAIL
https://reviews.freebsd.org/D8905
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com,
honzhan_microsoft.com,
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D8905#185507, @jhb wrote:
> I would suggest rewording the message a bit to something like:
>
> Defer if_up() until after the interface's if_ioctl method is called.
>
> This ensures the interface is initialize
sepherosa_gmail.com updated the summary for this revision.
REVISION DETAIL
https://reviews.freebsd.org/D8905
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com,
honzhan_microsoft.com, howard0su_gmail.c
jhb added a comment.
I would suggest rewording the message a bit to something like:
Defer if_up() until after the interface's if_ioctl method is called.
This ensures the interface is initialized by the interface driver before
it can be used by the rest of the system.
REVISI
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com,
honzhan_microsoft.com, howard0su_gmail.com, adrian, hiren, bz, gnn, glebius,
karels.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION SUMMARY
So if_{down,up}
