This revision was automatically updated to reflect the committed changes.
rstone marked an inline comment as done.
Closed by commit rS309372: Fix a false positive in a buf_ring assert (authored
by rstone).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D8685?vs=22633&id=22651#toc
REPOSITO
hselasky accepted this revision.
hselasky added a reviewer: hselasky.
hselasky added a comment.
This revision has a positive review.
Looks good to me.
REVISION DETAIL
https://reviews.freebsd.org/D8685
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rsto
rstone marked an inline comment as done.
rstone added inline comments.
INLINE COMMENTS
> hselasky wrote in buf_ring.h:71
> should "br->br_cons_head + 1" be masked by br->br_cons_mask ??
Absolutely correct. Nice catch, thank you
REVISION DETAIL
https://reviews.freebsd.org/D8685
EMAIL PREFERE
rstone updated this revision to Diff 22633.
rstone added a comment.
Ensure we don't walk off the end of the ring
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D8685?vs=22631&id=22633
REVISION DETAIL
https://reviews.freebsd.org/D8685
AFFECTED FILES
sys/sys/buf_ring.h
CHANGE DET
hselasky added inline comments.
INLINE COMMENTS
> buf_ring.h:71
> + if (br->br_cons_head != br->br_prod_head) {
> + for (i = br->br_cons_head + 1; i != br->br_prod_head;
> + i = ((i + 1) & br->br_cons_mask))
should "br->br_cons_head + 1" be masked by br->br_cons_m
rstone added a subscriber: freebsd-net-list.
REVISION DETAIL
https://reviews.freebsd.org/D8685
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rstone
Cc: freebsd-net-list, emaste
___
freebsd-net@freebsd.org mailin
