zlei added inline comments.
Herald added subscribers: melifaro, ae, imp.
INLINE COMMENTS
> ethernet.h:95
> #define EVL_MAKETAG(vlid, pri, cfi)
> \
> - ((pri) & 7) << 1) | ((cfi) & 1)) << 12) | ((vlid) & EVL_VLID_MASK))
>
`pri` is indeed shift
This revision was automatically updated to reflect the committed changes.
Closed by commit rS305177: net/vlan: Shift for pri is 13 (pri mask 0xe000) not
1. (authored by sephe).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D7710?vs=19837&id=19914#toc
REPOSITORY
rS FreeBSD src repositor
hselasky accepted this revision.
hselasky added a reviewer: hselasky.
hselasky added a comment.
Don't forget to MFC.
REVISION DETAIL
https://reviews.freebsd.org/D7710
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, glebius, bz, gnn,
araujo accepted this revision.
araujo added a comment.
This revision has a positive review.
It looks good for me.
On Linux implementation it is also 13.
Best,
REVISION DETAIL
https://reviews.freebsd.org/D7710
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailprefere
sepherosa_gmail.com added a comment.
I plan to commit this next Monday, if no objection comes.
REVISION DETAIL
https://reviews.freebsd.org/D7710
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, glebius, bz, gnn, rwatson, araujo, bms
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: glebius, bz, gnn, rwatson, araujo, bms.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION DETAIL
https://reviews.freebsd.org/D7710
AFFECTED FILES
sys/net/ethernet.h
CHANGE DETAILS
diff --git a/s
