This revision was automatically updated to reflect the committed changes.
Closed by commit rS304202: tcp/lro: Make # of LRO entries tunable (authored by
sephe).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D7499?vs=19270&id=19319#toc
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE
gallatin accepted this revision.
gallatin added a comment.
I tend to think type / range checking something like this is overkill.. I'm
OK with it as-is..
REVISION DETAIL
https://reviews.freebsd.org/D7499
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To
hselasky accepted this revision.
REVISION DETAIL
https://reviews.freebsd.org/D7499
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, rrs, gallatin, np, #transport, hselasky
Cc: freebsd-net-list
hselasky added inline comments.
INLINE COMMENTS
> tcp_lro.c:79
> +
> +static unsigned tcp_lro_entries = TCP_LRO_ENTRIES;
> +SYSCTL_UINT(_net_inet_tcp_lro, OID_AUTO, entries,
Maybe you should use a procedure type and range check the argument.
REVISION DETAIL
https://reviews.freebsd.org/D7
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: rrs, gallatin, hselasky, np.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
Herald added a reviewer: transport.
REVISION SUMMARY
Obtained from: rrs, gallatin
REVISION DETAIL
https://reviews.freebsd
