This revision was automatically updated to reflect the committed changes.
Closed by commit rS298974: tcp/lro: Refactor the active list operation.
(authored by sephe).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D6137?vs=15725&id=15841#toc
REPOSITORY
rS FreeBSD src repository
CHANGES
gallatin accepted this revision.
gallatin added a comment.
Thanks, I'm good w/this version
REVISION DETAIL
https://reviews.freebsd.org/D6137
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, network, adrian, delphij, glebius, hselasky
sepherosa_gmail.com updated this revision to Diff 15725.
sepherosa_gmail.com added a comment.
Skip the free list operation, which may introduce extra cmp on hot code path
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D6137?vs=15684&id=15725
REVISION DETAIL
https://reviews.freebsd.
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6137#130603, @gallatin wrote:
> The tcp_lro_entry_get() abstraction adds an extra compare to the critical
path (the compare against NULL in the function itself, in addition to the same
compare in the main routine). At
rrs added a comment.
It would be worth checking the assembly output.. if it truly inlines it then
it should probably only do one compare.. but worth checking...
REVISION DETAIL
https://reviews.freebsd.org/D6137
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreference
gallatin added a comment.
The tcp_lro_entry_get() abstraction adds an extra compare to the critical
path (the compare against NULL in the function itself, in addition to the same
compare in the main routine). At least it does at the C level. Have you
verified that the compiler is smart en
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, gallatin, rrs, adrian, delphij,
glebius, hselasky, np, decui_microsoft.com, honzhan_microsoft.com,
howard0su_gmail.com.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
Herald added a reviewer: trans
