[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org abandoned this revision. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neel

[Differential] D24989: netinet: Generate a random RSS key on boot.

damien.deville_stormshield.eu added a comment. Hi everyone, At stormshield we are using a similar hand-made patch so i can give you some feedback about this feature. We support symmetric and non-symmetric static or random rss key, using the following systctls: - net.inet.rss.ra

[Differential] D24989: netinet: Generate a random RSS key on boot.

adrian added a comment. i remember there was some concern in the past where there were very bad rss key choices out there. is there a reason for actually pushing for a random rss key? I stuck with the microsoft rss key (and a symmetric rss key at norse) specifically so there wouldn't be

[Differential] D24989: netinet: Generate a random RSS key on boot.

avg added a comment. In D24989#552693 , @neel_neelc.org wrote: > I believe Linux just uses random keys: > > - https://github.com/torvalds/linux/blob/29d9f30d4ce6c7a38745a54a8cddface10013490/net/ethtool/ioctl.c#L924 You are right. So, my

[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org added a comment. Should I sequence the key into "symmetrical RSS" where the first 32 bits == the next 32 bits, and all subsequent 16 bits chunks are equal?. Or is it something else? REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org

[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org added a comment. In D24989#552576 , @avg wrote: > I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies). > So, maybe just being random is not good enough? > I

[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org added a comment. I believe Linux just uses random keys: - https://github.com/torvalds/linux/blob/29d9f30d4ce6c7a38745a54a8cddface10013490/net/ethtool/ioctl.c#L924 Callers (example): - https://github.com/torvalds/linux/blob/29d9f30d4ce6c7a38745a54a8cddface10013490

[Differential] D24989: netinet: Generate a random RSS key on boot.

ae added a comment. In D24989#552576 , @avg wrote: > I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies). > So, maybe just being random is not good enough? > I think that h

[Differential] D24989: netinet: Generate a random RSS key on boot.

avg added a comment. I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies). So, maybe just being random is not good enough? I think that hypothetical `rss_isbadkey` was mentioned for a reason? REPOSITORY rS FreeBSD src

[Differential] D24989: netinet: Generate a random RSS key on boot.

markm requested changes to this revision. markm added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > rss_config.c:251 >*/ > + arc4random_buf(rss_key, RSS_KEYSIZE); > } This scares me less than the previously hard-coded key, but if we are going to

[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org updated this revision to Diff 72463. neel_neelc.org added a comment. @cem thanks for the comments. I fixed arc4random_buf(). About waiting for entropy, I think you're right. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org

[Differential] D24989: netinet: Generate a random RSS key on boot.

cem added inline comments. INLINE COMMENTS > kevans wrote in rss_config.c:251 > When in doubt, perhaps CC #csprng With #csprng hat on: The random subsystem does not guarantee it has been seeded at any point duri

[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org added a reviewer: csprng. neel_neelc.org added a project: csprng. neel_neelc.org added a subscriber: csprng. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFE

[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org added a comment. @kevans thanks for the suggestion, I added csprng to this thread. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFERENCES https://revie

[Differential] D24989: netinet: Generate a random RSS key on boot.

kevans added inline comments. INLINE COMMENTS > neel_neelc.org wrote in rss_config.c:251 > I'm not sure, I'm not an expert on entropy, but we could wait for entropy > before calling this. When in doubt, perhaps CC #csprng REPOSITORY rS FreeBSD src re

[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org added inline comments. INLINE COMMENTS > melifaro wrote in rss_config.c:251 > Are we sure that there is enough entropy available at the moment of calling > it? I'm not sure, I'm not an expert on entropy, but we could wait for entropy before calling this. REPOSITORY rS FreeBSD

[Differential] D24989: netinet: Generate a random RSS key on boot.

melifaro added inline comments. INLINE COMMENTS > rss_config.c:251 >*/ > + arc4random_buf(&rss_key, RSS_KEYSIZE); > } Are we sure that there is enough entropy available at the moment of calling it? REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.

[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org added a comment. Sure. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_ne

[Differential] D24989: netinet: Generate a random RSS key on boot.

debdrup added subscribers: rwatson, debdrup. debdrup added a comment. Did you mean to add some reviewers for this too? :) Looks like @rwatson might have some thoughts on this :) REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVIS

[Differential] D24989: netinet: Generate a random RSS key on boot.

neel_neelc.org created this revision. neel_neelc.org added a project: network. Herald added subscribers: Contributor Reviews (base), melifaro, ae, imp. neel_neelc.org requested review of this revision. REVISION SUMMARY netinet: Generate a random RSS key on boot. Submitted by: Neel Chauhan