[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

This revision was automatically updated to reflect the committed changes. Closed by commit rS350293: Allow set MTU more than 1500 bytes. (authored by krion). Herald added a subscriber: imp. CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D19422?vs=59753&id=60096#toc REPOSITORY rS FreeBSD

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

aleksandr.fedorov_itglobal.com added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D19422/new/ REVISION DETAIL https://reviews.freebsd.org/D19422 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: aleksandr.fedorov_itglobal.com,

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

aleksandr.fedorov_itglobal.com added a comment. Can anyone commit this patch? CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D19422/new/ REVISION DETAIL https://reviews.freebsd.org/D19422 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: aleksan

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

jhb accepted this revision. jhb added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D19422/new/ REVISION DETAIL https://reviews.freebsd.org/D19422 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/em

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

aleksandr.fedorov_itglobal.com marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D19422/new/ REVISION DETAIL https://reviews.freebsd.org/D19422 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: aleksandr.fedorov_itglob

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

aleksandr.fedorov_itglobal.com updated this revision to Diff 59753. aleksandr.fedorov_itglobal.com added a comment. VXLAN encapsulate ethernet frames within UDP/IP packets. So, we can calculate maximum overhead for IPv4: - IP_MAXPACKET = 65K - constant from netinet/ip.h. - Maximum IP he

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

jhb added a comment. I agree that we can't handle this in ether_ioctl as it varies too much by real hardware. INLINE COMMENTS > if_vxlan.c:90 > + */ > +#define VXLAN_MAX_MTU65435 > + If it was possible to make this derived from other constants that would be ideal. has ETHER_MAX_L

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

aleksandr.fedorov_itglobal.com marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D19422/new/ REVISION DETAIL https://reviews.freebsd.org/D19422 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: aleksandr.fedorov_itglob

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

aleksandr.fedorov_itglobal.com updated this revision to Diff 59684. aleksandr.fedorov_itglobal.com edited the test plan for this revision. aleksandr.fedorov_itglobal.com added reviewers: krion, jhb. aleksandr.fedorov_itglobal.com added a comment. This revision now requires review to proceed. I

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

hrs added a comment. Adding jumbo frame support looks good to me. However, is it better to support this in ether_ioctl() instead of a driver-specific ioctl handler? Check of (ifr->ifr_mtu > ETHERMTU) in ether_ioctl() can be changed to check if the interface has IFCAP_JUMBO_MTU or not. IN

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

rgrimes accepted this revision as: rgrimes. This revision is now accepted and ready to land. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D19422/new/ REVISION DETAIL https://reviews.freebsd.org/D19422 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

aleksandr.fedorov_itglobal.com created this revision. aleksandr.fedorov_itglobal.com added reviewers: bryanv, hrs, network. Herald added a subscriber: ae. REVISION SUMMARY It seems, there are no reason to prevent setting MTU more than 1500 bytes. MTU greater than 1500 gives a significant incre