[Differential] [Updated] D1777: Associated fix for arp/nd6 timer usage.

2015-03-24 Thread sbruno (Sean Bruno)
sbruno added a comment. Randall: Do you want to close this review as committed? The commit hook doesn't seem to have fired to close this when comitted at svn r278472 REVISION DETAIL https://reviews.freebsd.org/D1777 To: rrs, imp, gnn, rwatson, lstewart, kostikbel, adrian, jhb, bz, sbruno Cc

[Differential] [Updated] D1777: Associated fix for arp/nd6 timer usage.

2015-02-08 Thread bz (Bjoern A. Zeeb)
bz added a comment. Hiren, it only took us 4 years to trigger this? Can people actually easily/reliably reproduce it? REVISION DETAIL https://reviews.freebsd.org/D1777 To: rrs, imp, sbruno, gnn, rwatson, lstewart, kostikbel, adrian, jhb, bz Cc: bz, emaste, hiren, julian, hselasky, freebsd-ne

[Differential] [Updated] D1777: Associated fix for arp/nd6 timer usage.

2015-02-04 Thread jhb (John Baldwin)
jhb added a comment. This is just "How It Works". You are always supposed to do a callout_drain() before freeing the storage belonging to a callout. I don't understand how you are preventing the callout/lock being freed out from under the callout routine in this version either. Now you can h

[Differential] [Updated] D1777: Associated fix for arp/nd6 timer usage.

2015-02-04 Thread adrian (Adrian Chadd)
adrian added a comment. I'm still a little iffy about this kind of fix. It looks more like a lifecycle management thing that we should fix, rather than just moving to MPSAFE. But I unfortunately don't have the time to go look at the lle code and figure out how it should look. :( REVISION DETAI